-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Floorplanner settings moved to Configuration... #17
base: master
Are you sure you want to change the base?
Conversation
…ards using 3D with own scenegraph
… creation of walls toggled by bool flag WIP
…eprint3d extension
… concatenated cornerpoint uids ALPHABETICALLY SORTED and then concatenated
…r rendering in different scale via BP3D.Three.CmToWorld (default is 1)
Changes to inject room into foreign scenegraph, more typescript types
@@ -0,0 +1,4 @@ | |||
Nils Todo List: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't check this in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, ignore pls
@@ -3,9 +3,19 @@ | |||
/// <reference path="../core/utils.ts" /> | |||
|
|||
module BP3D.Three { | |||
export var Edge = function (scene, edge, controls) { | |||
|
|||
export class HierarchyConfig { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of HierarchyConfig?
Hi Ekki, Thanks for all this. Apologies for not getting a chance to review it sooner. Just a small ask: going forward it would be helpful to split unrelated changes into multiple Pull Requests so they can be reviewed and merged faster. |
/// <reference path="wall.ts" /> | ||
/// <reference path="corner.ts" /> | ||
/// <reference path="room.ts" /> | ||
/// <reference path="half_edge.ts" /> | ||
|
||
module BP3D.Model { | ||
/** */ | ||
const defaultFloorPlanTolerance = 10.0; | ||
const defaultFloorPlanTolerance = 10.0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert?
Hi Pete, maybe it's to late for the upcoming rq but will consider splitting in the future Ekki Sent from my iPhone 5SE, iOS 9.3.3, paired with WATCH Sport, 1st Gen., watchOS 2.2.1, supported by OS X Server 5.1.7
|
... making it easy to load&save such settings from a (user) profile
Should the defaults be added to the typedocs too?