Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floorplanner settings moved to Configuration... #17

Open
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

Ekki
Copy link
Contributor

@Ekki Ekki commented Jul 14, 2016

... making it easy to load&save such settings from a (user) profile

Should the defaults be added to the typedocs too?

Ekki and others added 23 commits July 14, 2016 20:33
… creation of walls toggled by bool flag WIP
… concatenated cornerpoint uids ALPHABETICALLY SORTED and then concatenated
…r rendering in different scale via BP3D.Three.CmToWorld (default is 1)
Changes to inject room into foreign scenegraph, more typescript types
@@ -0,0 +1,4 @@
Nils Todo List:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't check this in?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, ignore pls

@@ -3,9 +3,19 @@
/// <reference path="../core/utils.ts" />

module BP3D.Three {
export var Edge = function (scene, edge, controls) {

export class HierarchyConfig {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of HierarchyConfig?

@pshaw
Copy link
Collaborator

pshaw commented Aug 7, 2016

Hi Ekki,

Thanks for all this. Apologies for not getting a chance to review it sooner. Just a small ask: going forward it would be helpful to split unrelated changes into multiple Pull Requests so they can be reviewed and merged faster.

/// <reference path="wall.ts" />
/// <reference path="corner.ts" />
/// <reference path="room.ts" />
/// <reference path="half_edge.ts" />

module BP3D.Model {
/** */
const defaultFloorPlanTolerance = 10.0;
const defaultFloorPlanTolerance = 10.0;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert?

@Ekki
Copy link
Contributor Author

Ekki commented Aug 7, 2016

Hi Pete,

maybe it's to late for the upcoming rq but will consider splitting in the future

Ekki

Sent from my iPhone 5SE, iOS 9.3.3, paired with WATCH Sport, 1st Gen., watchOS 2.2.1, supported by OS X Server 5.1.7

On 07 Aug 2016, at 15:57, Peter Shaw notifications@github.com wrote:

Hi Ekki,

Thanks for all this. Apologies for not getting a chance to review it sooner. Just a small ask: going forward it would be helpful to split unrelated changes into multiple Pull Requests so they can be reviewed and merged faster.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants