Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arrow actor needs to use repeat_primitives by default #530

Closed
skoudoro opened this issue Jan 21, 2022 · 3 comments
Closed

Arrow actor needs to use repeat_primitives by default #530

skoudoro opened this issue Jan 21, 2022 · 3 comments
Labels
good first issue Good for newcomers type:Enhancement

Comments

@skoudoro
Copy link
Contributor

This will allow the arrow to have the same behavior when picking vertices or edges as with other primitives.

However, we should also keep repeat_sources as a secondary option just in case we need to use some of the other VTK filters.

See an example of box actor (using repeat_primitives) here https://github.com/fury-gl/fury/blob/master/fury/actor.py#L1696

See the current implementation of arrow here https://github.com/fury-gl/fury/blob/master/fury/actor.py#L1768
@soma2000-lang
Copy link

@skoudoro I am working on this

@m-agour m-agour mentioned this issue Mar 8, 2022
Merged
@Aditi840
Copy link

Aditi840 commented Mar 9, 2022

hello, I saw this issue open can I on this.

@skoudoro
Copy link
Contributor Author

fixed by @m-agour on #552. closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers type:Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@skoudoro @Aditi840 @soma2000-lang