Modified Arrow actor to use repeat primitive by default

[m-agour]

Modified Arrow actor to use repeat primitive by default as specified in issue #530.

Test code

import numpy as np  
from fury import window, actor  
  
scene = window.Scene()  
  
center_rs = np.array([[0, 0, 0]])  
center_rp = np.array([[0, 1, 0]])  
direction = np.array([[0, 0, 0]])  
color_rs = np.array([[1, 0, 0]])  
color_rp = np.array([[0, 1, 0]])  
  
rpactor = actor.arrow(center_rp, direction, colors=color_rp, scales=1)  
rsactor = actor.arrow(center_rs, direction, colors=color_rs, repeat_primitive=False)  
  
scene.add(rpactor)  
scene.add(rsactor)  
  
window.show(scene, size=(600, 600), reset_camera=False, title='Comparing')

[pep8speaks]

Hello @m-agour! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file docs/tutorials/01_introductory/viz_arrow.py:

Line 51:66: W292 no newline at end of file

Comment last updated at 2022-04-08 23:33:36 UTC

[skoudoro]

Hi @m-agour,

Thank you for this! This is a busy month, I will review your PR ASAP. Maybe @guaje, @Garyfallidis, or other maintainers will be available to review your PR earlier.

During this time, can you make sure to add/fix:

• pep8
• Unit test (check the other primitives tests)
• update or add a tutorial
• check orientation
• add on this PR different screenshots.

Thanks

[m-agour]

Hello @skoudoro,
Taking your advice, I've checked the orientation of the arrow actor and found two problems:

1. By setting the direction of the repeate_source based arrow to (0, 0, 0), I found that the original direction of the arrow is (1, 0, 0). so I edited the prim_arrow to point at that direction.
2. The second problem is that the rotation of the repeat_sources is not the same as the repeat_primitive rotation for the same arrow object. I will write about it in more detail in a separate issue.

[m-agour]

Hello @skoudoro .
I've made some progress. Would you take a look at it and let me know if anything is missing?

[skoudoro]

Thank you for this @m-agour. merging