-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the rotation matrix in repeat_primitive. #555
Conversation
… and actor mapping. If a vtkSource is not aligned with the X axis, provide 4x4 orientation matrix to repeat_sources to align
…lyphs which must be oriented before mapping to actors
…dicular to the camera
…r to camera's focal point
Fixed rotation matrix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @m-agour,
Apologize for the late answer. Good catch and thank you for this!
Can you update the tests in fury/test/test_primitive.py
Thank you
Hello @skoudoro , |
Hello @skoudoro . |
Thank you @m-agour for adding the tests, merging |
Fixed the issue of the rotation matrix that I mentioned in issue #554.
What I did was assume all primitives have a normal vector pointing in X-axis (1, 0, 0), then the matrix to align this normal vector of the primitives to the direction vector specified.
I tested the matrix on my arrow using repeat_primitive and repeat_source and got a match.
As shown in the figure above, they align perfectly now.