does not work with pages without title tag

[ataiger]

Tab Modifier version

0.19.2

Expected behavior

work with pages without <title> tag

(on these pages, chrome displays the url. what I want to do is to change that.)

Actual behavior

does not work

Steps to reproduce the behavior

thanks for nice work!

[sylouuu]

Hi @ataiger,

TM is HTML-based. There is no way to change a tab title without HTML (as I know). I'll add this known issue in the README.

Best

[ataiger]

thanks for quick response.

so the extension can change the content of the title tag, but cannot create a title tag if the page didn't have one in the first place?

[sylouuu]

I wondered if you talked about an HTML page without <title> tag or a non-HTML page?

Can you give me a link please?

[ataiger]

it is an html page without title tag law.go.kr/법령/민법 I wonder if it matters but the url contains Korean letters 2017. 4. 19. 오후 6:25 Syl <notifications@github.com> 작성:

…

I wondered if you talked about an HTML page without <title> tag or a non-HTML page? Can you give me a link please? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[sylouuu]

I found why the title is not applied. At load, the title is an empty string because the website is loading dynamically. If I remove the empty string check it works.

I'll release a patch in few hours, be sure to opt-in the notification in TM settings to know when TM is updated.

Best

[ataiger]

thanks a lot!! ;) 2017. 4. 19. 오후 6:58 Syl <notifications@github.com> 작성:

…

I found why the title is not applied. At load, the title is an empty string because the website is loading dynamically. If I remove the empty string check it works. I'll release a patch in few hours, be sure to opt-in the notification in TM settings to know when TM is updated. Best — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.