Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fuse.Platform: make internals visible to Fuse.Entities #1202

Merged
merged 1 commit into from
Jul 1, 2018

Conversation

mortend
Copy link
Member

@mortend mortend commented Jun 30, 2018

Otherwise we'll get build errors when using this package on mobile.

Fuse.Entities are using Fuse.Platform.SystemUI.FrameChanged here:
https://github.com/fuse-open/Fuse.Entities/blob/master/src/Scene.uno#L9

Maybe there's a better way to fix this, but this was the quickest route I found.

This PR contains:

  • Changelog
  • Documentation
  • Tests

Otherwise we'll get build errors when using this package on mobile.

Fuse.Entities are using Fuse.Platform.SystemUI.FrameChanged here:
https://github.com/fuse-open/Fuse.Entities/blob/master/src/Scene.uno#L9
Copy link
Contributor

@kusma kusma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is a nice and easy fix.

@kusma kusma merged commit fd2708c into fuse-open:master Jul 1, 2018
@mortend mortend deleted the fix-fuse-entities branch July 1, 2018 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants