Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding more type hints #250

Merged
merged 8 commits into from
Jun 28, 2022
Merged

Adding more type hints #250

merged 8 commits into from
Jun 28, 2022

Conversation

shimwell
Copy link
Member

Proposed changes

Adding more type hints to the parametric components

@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #250 (6725d42) into develop (297a76b) will increase coverage by 0.56%.
The diff coverage is 95.71%.

❗ Current head 6725d42 differs from pull request most recent head 670a999. Consider uploading reports for the commit 670a999 to get more accurate results

@@             Coverage Diff             @@
##           develop     #250      +/-   ##
===========================================
+ Coverage    94.77%   95.33%   +0.56%     
===========================================
  Files           82       82              
  Lines         5507     5511       +4     
===========================================
+ Hits          5219     5254      +35     
+ Misses         288      257      -31     
Impacted Files Coverage Δ
...etric_components/center_column_plasma_dependant.py 100.00% <ø> (ø)
...rametric_components/coolant_channel_ring_curved.py 100.00% <ø> (ø)
paramak/parametric_components/hollow_cube.py 100.00% <ø> (ø)
paramak/parametric_components/tokamak_plasma.py 100.00% <ø> (ø)
...tric_components/tokamak_plasma_plasmaboundaries.py 100.00% <ø> (ø)
...ic_components/toroidal_field_coil_round_corners.py 93.88% <ø> (ø)
...k/parametric_components/constant_thickness_dome.py 92.85% <70.00%> (+0.07%) ⬆️
.../parametric_components/blanket_cutter_parallels.py 100.00% <100.00%> (ø)
...amak/parametric_components/blanket_cutters_star.py 100.00% <100.00%> (ø)
paramak/parametric_components/blanket_fp.py 100.00% <100.00%> (ø)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 297a76b...670a999. Read the comment docs.

@shimwell
Copy link
Member Author

error appears to be unrelated to the PR and can be looked into separately

Encountered problems while solving:
-   - package moab-5.3.1-nompi_notempest_py38h11ddcca_100 requires hdf5 >=1.12.1,<1.12.2.0a0, but none of the providers can be installed

@shimwell shimwell merged commit 2a1ed3b into develop Jun 28, 2022
@shimwell shimwell deleted the adding_more_type_hints branch June 28, 2022 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant