Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compound instead of union #271

Merged
merged 2 commits into from
Oct 12, 2022
Merged

Conversation

shimwell
Copy link
Member

attempt to fix bug reported in issue #270

@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #271 (d260ce6) into develop (6d4d78a) will increase coverage by 0.18%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #271      +/-   ##
===========================================
+ Coverage    96.30%   96.48%   +0.18%     
===========================================
  Files           82       82              
  Lines         5523     5524       +1     
===========================================
+ Hits          5319     5330      +11     
+ Misses         204      194      -10     
Impacted Files Coverage Δ
...amak/parametric_components/dished_vacuum_vessel.py 82.50% <100.00%> (+0.44%) ⬆️
src/paramak/shape.py 97.41% <0.00%> (+0.34%) ⬆️
src/paramak/utils.py 94.87% <0.00%> (+2.15%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@shimwell shimwell merged commit 1968359 into develop Oct 12, 2022
@shimwell shimwell deleted the fixing_DishedVacuumVessel_when_rotated branch October 12, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant