Implement CI for multiple node versions (#328)

Implements Docker services for running against multiple node versions at once using a build arg.
Curently runs against node 8 and node 10.

.buildkite/pipeline.yml

@@ -6,6 +6,13 @@ steps:
         image-repository: 027047743804.dkr.ecr.us-east-2.amazonaws.com/uber
     agents:
       queue: builders
+  - name: ':docker: :package: node8'
+    plugins:
+      'docker-compose#v1.7.0':
+        build: fusion-core-node-last
+        image-repository: 027047743804.dkr.ecr.us-east-2.amazonaws.com/uber
+    agents:
+      queue: builders
   - wait
   - command: yarn flow
     name: ':flowtype:'
@@ -14,24 +21,52 @@ steps:
         run: fusion-core
     agents:
       queue: workers
+  - command: yarn flow
+    name: ':flowtype: node8'
+    plugins:
+      'docker-compose#v1.7.0':
+        run: fusion-core-node-last
+    agents:
+      queue: workers
   - name: ':eslint:'
     command: yarn lint
     plugins:
       'docker-compose#v1.7.0':
         run: fusion-core
     agents:
       queue: workers
+  - name: ':eslint: node8'
+    command: yarn lint
+    plugins:
+      'docker-compose#v1.7.0':
+        run: fusion-core-node-last
+    agents:
+      queue: workers
   - name: ':chrome: :white_check_mark:'
     command: .buildkite/browserTests
     plugins:
       'docker-compose#v1.7.0':
         run: fusion-core
     agents:
       queue: workers
+  - name: ':chrome: :white_check_mark: node8'
+    command: .buildkite/browserTests
+    plugins:
+      'docker-compose#v1.7.0':
+        run: fusion-core-node-last
+    agents:
+      queue: workers
   - name: ':node: :white_check_mark:'
     command: .buildkite/nodeTests
     plugins:
       'docker-compose#v1.7.0':
         run: fusion-core
     agents:
       queue: workers
+  - name: ':node: :white_check_mark: node8'
+    command: .buildkite/nodeTests
+    plugins:
+      'docker-compose#v1.7.0':
+        run: fusion-core-node-last
+    agents:
+      queue: workers

Dockerfile

@@ -1,4 +1,5 @@
-FROM uber/web-base-image:1.0.9@sha256:98ad970fd8dadc43ecec9909e27dc543a88d096f722d00e07e0b25047e9388bc
+ARG BASE_IMAGE=uber/web-base-image:2.0.0
+FROM $BASE_IMAGE
 
 WORKDIR /fusion-core
 

docker-compose.yml

@@ -3,7 +3,7 @@ services:
   fusion-core:
     build: .
     volumes:
-      - .:/fusion-core
+      - '.:/fusion-core'
       - /fusion-core/node_modules/
       - /fusion-core/dist/
       - /fusion-core/dist-tests/
@@ -17,3 +17,9 @@ services:
       - BUILDKITE_BUILD_URL
       - BUILDKITE_PROJECT_SLUG
       - BUILDKITE_COMMIT
+  fusion-core-node-last:
+    extends: fusion-core
+    build:
+      context: .
+      args:
+        BASE_IMAGE: 'uber/web-base-image:1.0.9'