This repository has been archived by the owner on May 17, 2019. It is now read-only.
Disable flow temporarily for failing 0.85 upgrade #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to fusion-core being a commonly used dependency, we should unblock upgrades by quickly fixing fusion-core with a FlowFixMe and a pre-release. We should still fix fusion-core before the next Fusion.js release.
Codecov Report
@@ Coverage Diff @@
## master #337 +/- ##
=======================================
Coverage 93.67% 93.67%
=======================================
Files 18 18
Lines 443 443
Branches 86 86
=======================================
Hits 415 415
Misses 15 15
Partials 13 13
Continue to review full report at Codecov.
|
AlexMSmithCA
approved these changes
Nov 7, 2018
|
!merge |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to fusion-core being a commonly used dependency, we should unblock upgrades by quickly fixing fusion-core with a FlowFixMe and a pre-release. We should still fix fusion-core before the next Fusion.js release.