Fix types... sort of #347
Fix types... sort of #347
Conversation
Still lots of $FlowFixMe's in tests because they are explicitly testing error messages that are triggered when arguments are of the wrong type Also, lots of existential operators left because removing them is going to be highly non-trivial
Codecov Report
@@ Coverage Diff @@
## master #347 +/- ##
=========================================
+ Coverage 93.17% 93.2% +0.02%
=========================================
Files 18 18
Lines 454 456 +2
Branches 89 91 +2
=========================================
+ Hits 423 425 +2
Misses 17 17
Partials 14 14
Continue to review full report at Codecov.
|
| @@ -13,8 +13,13 @@ import {SSRDecider} from './plugins/ssr'; | |||
|
|
|||
| import type {aliaser, cleanupFn, FusionPlugin, Token} from './types.js'; | |||
|
|
|||
| interface Register<T> { | |||
There was a problem hiding this comment.
The only reason we have the flow.js file was because we were unable to find a way to do method overloading. If this works, then that means we can probably get rid of that file, should we?
https://github.com/fusionjs/fusion-core/blob/master/src/base-app.js.flow#L26-L33
There was a problem hiding this comment.
I think we should keep the flow file if that's what gets used by any file other than base-app.js.flow. Internally, base-app.js still has a lot of *'s so I'd rather expose a more stable interface to its consumers
Still lots of
$FlowFixMe's in tests because they are explicitly testing error messages that are triggered when arguments are of the wrong type. Most of these are inconsequential and can be ignored.Also, lots of existential operators left because removing them is going to be highly non-trivial. The bulk of these existential operators exist as pass-through placeholders to glue the
TofToken<T>to their respective plugins. Removing them will involve app.register require a generic arg, which will require codemodding apps in the wild.One battle at a time.