Skip to content
This repository has been archived by the owner on May 17, 2019. It is now read-only.

Include svg and js.map in the extension list determining SSR #373

Merged
merged 2 commits into from
Mar 20, 2019

Conversation

ganemone
Copy link
Contributor

@ganemone ganemone commented Mar 20, 2019

This will ensure svg and sourcemap asset requests will not result in an SSR being triggered

KevinGrandon
KevinGrandon previously approved these changes Mar 20, 2019
rtsao
rtsao previously approved these changes Mar 20, 2019
@codecov
Copy link

codecov bot commented Mar 20, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@5572da5). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #373   +/-   ##
=========================================
  Coverage          ?   93.24%           
=========================================
  Files             ?       18           
  Lines             ?      459           
  Branches          ?       91           
=========================================
  Hits              ?      428           
  Misses            ?       17           
  Partials          ?       14
Impacted Files Coverage Δ
src/plugins/ssr.js 91.3% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5572da5...6775ef3. Read the comment docs.

@ganemone ganemone dismissed stale reviews from rtsao and KevinGrandon via 6775ef3 March 20, 2019 20:34
@ganemone ganemone changed the title Include svg in the extension list determining SSR Include svg and js.map in the extension list determining SSR Mar 20, 2019
@ganemone ganemone merged commit 5755a73 into fusionjs:master Mar 20, 2019
@old-fusion-bot
Copy link

Triggered Fusion.js build verification: https://buildkite.com/uberopensource/fusion-release-verification/builds/1766

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants