Merge pull request #294 from jackbayliss/hotfix/reorder-set-page-attr…

…ibutes Reorders set page attributes
fusionspim · Nov 5, 2024 · e649499 · e649499
2 parents bfdd9bc + cb2b7cb
commit e649499
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/src/Writer/Entity/Category.php b/src/Writer/Entity/Category.php
@@ -70,7 +70,7 @@ public function setSitemap(?float $sitemapPriority = null, bool $sitemapIncluded
         $this->sitemapChangeFrequency = $sitemapChangeFrequency;
     }
 
-    public function setPageAttributes(?string $pageTitle = null, ?string $pageDescription = null, ?string $pageKeywords = null, ?string $pageUrl = null): void
+    public function setPageAttributes(?string $pageTitle = null, ?string $pageDescription = null, ?string $pageUrl = null, ?string $pageKeywords = null): void
     {
         $this->pageAttributes = [
             'page-title'       => $pageTitle,

diff --git a/src/Writer/Entity/Product.php b/src/Writer/Entity/Product.php
@@ -146,7 +146,7 @@ public function setSitemap(?float $sitemapPriority = null, bool $sitemapIncluded
         $this->sitemapChangeFrequency = $sitemapChangeFrequency;
     }
 
-    public function setPageAttributes(?string $pageTitle, ?string $pageDescription, ?string $pageKeywords, ?string $pageUrl): void
+    public function setPageAttributes(?string $pageTitle = null, ?string $pageDescription = null, ?string $pageUrl = null, ?string $pageKeywords = null): void
     {
         $this->pageAttributes = [
             'page-title'       => $pageTitle,

diff --git a/tests/Writer/CategoriesTest.php b/tests/Writer/CategoriesTest.php
@@ -54,7 +54,7 @@ public function test_categories_xml(): void
             $element->setTemplate('cat-listings.html');
             $element->setOnlineFlag(true);
             $element->setSitemap(0.2);
-            $element->setPageAttributes($title, 'Buy ' . $title, mb_strtolower($title), '/' . $title);
+            $element->setPageAttributes($title, 'Buy ' . $title, '/' . $title, mb_strtolower($title));
             $element->setOnlineFromTo(
                 $data['dates']['from'],
                 $data['dates']['to']

diff --git a/tests/Writer/ProductsTest.php b/tests/Writer/ProductsTest.php
@@ -135,8 +135,8 @@ protected function buildBaseElement(string $type, int $number = 0): Product
         $element->setPageAttributes(
             'Amazing ' . $type,
             'Buy our ' . $type . ' today!',
+            'http://example.com/' . mb_strtolower($type) . '/123',
             $type . ', test, example',
-            'http://example.com/' . mb_strtolower($type) . '/123'
         );
 
         $element->addCustomAttributes([