Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Add a method for filtering the result with a type #7

Merged
merged 5 commits into from
Nov 16, 2014
Merged

Add a method for filtering the result with a type #7

merged 5 commits into from
Nov 16, 2014

Conversation

minidfx
Copy link
Contributor

@minidfx minidfx commented Nov 13, 2014

Based on .NET Linq method. Useful in some case for me.

@davidroth
Copy link
Member

Hi, thanks for the pull-request!
Looks great!
One thing: Could you please use our default header template in OfTypeIterator.php?

Example: https://github.com/fusonic/linq/blob/master/src/Fusonic/Linq/Iterator/WhereIterator.php

@@ -0,0 +1,91 @@
<?php
/**
* Created by PhpStorm.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use our default header template as in: https://github.com/fusonic/linq/blob/master/src/Fusonic/Linq/Iterator/WhereIterator.php
Obviously replace "Author" with your Name ;)

@minidfx
Copy link
Contributor Author

minidfx commented Nov 14, 2014

Oh sorry! I will do that tonight.

davidroth added a commit that referenced this pull request Nov 16, 2014
Add a method for filtering the result with a type
@davidroth davidroth merged commit 4b0602d into fusonic:master Nov 16, 2014
@minidfx minidfx deleted the ofType branch November 16, 2014 14:56
@davidroth
Copy link
Member

@minidfx Thanks for the contribution!
Happy to see the library is useful for some folks :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants