Consolidate local playbooks #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jwmatthews what do you think about consolidating our local playbooks and using variables instead? |
jwmatthews
reviewed
Jun 16, 2017
| @@ -39,7 +39,6 @@ | |||
| -p DOCKERHUB_USER={{ dockerhub_user_name }} | |||
| -p LAUNCH_APB_ON_BIND={{ broker_launch_apb_on_bind }} | |||
| -p OUTPUT_REQUEST={{ broker_output_request }} | |||
| -p RECOVERY={{ broker_recovery }} | |||
There was a problem hiding this comment.
I think we will want to add this back now that the recovery pr has merged
There was a problem hiding this comment.
thanks for catching that, that was unintentional
cfchase
changed the title
cfchase
commented
Jun 16, 2017
| @@ -78,7 +78,7 @@ | |||
| url: http://{{ ansible_service_broker_route }}/v2/bootstrap | |||
| method: POST | |||
| register: response | |||
| until: response|success and response.json and response.json.spec_count | |||
| until: response|success and response.json and response.json.spec_count is defined | |||
There was a problem hiding this comment.
This change keeps catasb from failing whenever someone doesn't have any apbs yet.
|
Would you also update the README's to coincide, assume we need some directions to create my_vars.yml a level up, also some mention of the other .yml being shared in local directory. |
dymurray
approved these changes
Jun 20, 2017
| dockerhub_org_name: example_org | ||
|
|
||
| # Omit this unless you want to store your password in plain text to skip prompts. | ||
| # dockerhub_user_password: example_password |
There was a problem hiding this comment.
Good idea to have a special note about this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.