Buildkit implementation #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fussybeaver
force-pushed
the
ND-buildkit
branch
6 times, most recently
from
8560626
to
3440d71
Compare
Description: - Build images using buildkit - Adds git submodules for buildkit gRPC codegen - Doesn't work yet, but we get a HTTP 101 when upgrading via /session endpoint on the docker API
fussybeaver
force-pushed
the
ND-buildkit
branch
5 times, most recently
from
9727734
to
44d0ab1
Compare
fussybeaver
force-pushed
the
ND-buildkit
branch
from
44d0ab1
to
187fb89
Compare
Connects to Docker's built-in buildkit grpc client. Contains an example and integration test. This PR does not authenticate to private registries. Windows CI is disabled, so unsure this works there.
fussybeaver
force-pushed
the
ND-buildkit
branch
from
187fb89
to
150a669
Compare
|
Any shot you can cut a release on this? We'd love to use it for https://github.com/railwayapp/nixpacks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows prior work in #264 .
Connects to Docker's built-in buildkit grpc client.
To try, use feature
buildkit. Specify the correctversioninBuildImageOptionsand specify an arbitrary uniquesessionto identify with the grpc client. There is an example inexamples/build_buildkit.rs, which uses a local tar approach, but a remote Dockerfile should also work.This PR does not do authentication to a private registry. I'm also unsure if the windows version of Docker works.
Closes #264
Closes #237