Omit changes query parameter in CreateImageOptions if Vec is empty
#353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not on my desktop at the moment, but looks good... Would also be good to get a test case around the wasm use case that you mentioned. |
Sure thing, I'll write one now (making sure it fails without the fix) |
|
Done |
fussybeaver
reviewed
Nov 20, 2023
| .into_iter() | ||
| .collect::<Result<Vec<_>, bollard::errors::Error>>() | ||
| .unwrap(); | ||
|
|
There was a problem hiding this comment.
Could we assert that the image was built by using inspect_image?
|
Thanks, looks good, happy to merge if we can get one assert in there |
Resolves an issue where if an empty changes parameter is sent, Docker will return a 400 "file with no instructions" error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #352