Reduce regular expression compilation #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Basically all the regular expressions should be compiled at the top level, outside the functions for consistency. I agree with the opinion but it can lead to lower readability, more initialisation when you support many platforms. But if you don't mind it, I'll move them all. |
|
Thanks for sending P/R :)
Readability is more important than performance for Vuls. Would you merge in only one commit? |
- use regexp.MustCompile instead of regexp.Compile - use strings.HasPrefix instead of regular expression when it is enough
|
Okay. I've squashed the commits. |
|
Many Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I've started reading the code of vuls yesterday and noticed the many regexp compilation on runtime. Specifically, we should avoid calling regexp.Compile in loops because it affects the performance badly. What do you think?