Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dictionary tools, Vuls is now CGO free #1667

Merged
merged 2 commits into from
May 10, 2023

Conversation

MaineK00n
Copy link
Collaborator

@MaineK00n MaineK00n commented Apr 27, 2023

What did you implement:

By updating tools that were dependent on CGO, they are now CGO-free.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

before

$ CGO_ENABLED=0 GO111MODULE=on go build -a -ldflags "-X 'github.com/future-architect/vuls/config.Version=v0.23.1' -X 'github.com/future-architect/vuls/config.Revision=build-20230427_133232_3cc7e92'" -o vuls ./cmd/vuls
# github.com/vulsio/go-kev/db
../../../../go/pkg/mod/github.com/vulsio/go-kev@v0.1.1/db/rdb.go:79:24: undefined: sqlite3.Error
../../../../go/pkg/mod/github.com/vulsio/go-kev@v0.1.1/db/rdb.go:80:17: undefined: sqlite3.ErrLocked
../../../../go/pkg/mod/github.com/vulsio/go-kev@v0.1.1/db/rdb.go:80:36: undefined: sqlite3.ErrBusy
# github.com/vulsio/goval-dictionary/db
../../../../go/pkg/mod/github.com/vulsio/goval-dictionary@v0.8.2/db/rdb.go:81:24: undefined: sqlite3.Error
../../../../go/pkg/mod/github.com/vulsio/goval-dictionary@v0.8.2/db/rdb.go:82:17: undefined: sqlite3.ErrLocked
../../../../go/pkg/mod/github.com/vulsio/goval-dictionary@v0.8.2/db/rdb.go:82:36: undefined: sqlite3.ErrBusy
# github.com/vulsio/go-exploitdb/db
../../../../go/pkg/mod/github.com/vulsio/go-exploitdb@v0.4.4/db/rdb.go:80:24: undefined: sqlite3.Error
../../../../go/pkg/mod/github.com/vulsio/go-exploitdb@v0.4.4/db/rdb.go:81:17: undefined: sqlite3.ErrLocked
../../../../go/pkg/mod/github.com/vulsio/go-exploitdb@v0.4.4/db/rdb.go:81:36: undefined: sqlite3.ErrBusy
# github.com/vulsio/go-msfdb/db
../../../../go/pkg/mod/github.com/vulsio/go-msfdb@v0.2.1/db/rdb.go:80:24: undefined: sqlite3.Error
../../../../go/pkg/mod/github.com/vulsio/go-msfdb@v0.2.1/db/rdb.go:81:17: undefined: sqlite3.ErrLocked
../../../../go/pkg/mod/github.com/vulsio/go-msfdb@v0.2.1/db/rdb.go:81:36: undefined: sqlite3.ErrBusy
# github.com/vulsio/go-cve-dictionary/db
../../../../go/pkg/mod/github.com/vulsio/go-cve-dictionary@v0.8.3/db/rdb.go:83:24: undefined: sqlite3.Error
../../../../go/pkg/mod/github.com/vulsio/go-cve-dictionary@v0.8.3/db/rdb.go:84:17: undefined: sqlite3.ErrLocked
../../../../go/pkg/mod/github.com/vulsio/go-cve-dictionary@v0.8.3/db/rdb.go:84:36: undefined: sqlite3.ErrBusy
# github.com/vulsio/go-cti/db
../../../../go/pkg/mod/github.com/vulsio/go-cti@v0.0.2/db/rdb.go:79:24: undefined: sqlite3.Error
../../../../go/pkg/mod/github.com/vulsio/go-cti@v0.0.2/db/rdb.go:80:17: undefined: sqlite3.ErrLocked
../../../../go/pkg/mod/github.com/vulsio/go-cti@v0.0.2/db/rdb.go:80:36: undefined: sqlite3.ErrBusy
# github.com/vulsio/gost/db
../../../../go/pkg/mod/github.com/vulsio/gost@v0.4.3-0.20230420081542-e248764c0eee/db/rdb.go:75:24: undefined: sqlite3.Error
../../../../go/pkg/mod/github.com/vulsio/gost@v0.4.3-0.20230420081542-e248764c0eee/db/rdb.go:76:17: undefined: sqlite3.ErrLocked
../../../../go/pkg/mod/github.com/vulsio/gost@v0.4.3-0.20230420081542-e248764c0eee/db/rdb.go:76:36: undefined: sqlite3.ErrBusy

after

$ CGO_ENABLED=0 go build -a -ldflags "-X 'github.com/future-architect/vuls/config.Version=v0.23.1' -X 'github.com/future-architect/vuls/config.Revision=build-20230427_133148_b4b66ef'" -o vuls ./cmd/vuls

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

Reference

@MaineK00n MaineK00n self-assigned this Apr 27, 2023
@MaineK00n MaineK00n changed the title chore(deps): update dictionary tools chore(deps): update dictionary tools, Vuls is now CGO free Apr 27, 2023
@MaineK00n MaineK00n force-pushed the MaineK00n/update-dict branch 3 times, most recently from 89879f4 to b97d19a Compare April 27, 2023 05:06
@MaineK00n MaineK00n force-pushed the MaineK00n/update-dict branch from b97d19a to e533ea1 Compare May 10, 2023 14:22
@MaineK00n MaineK00n force-pushed the MaineK00n/update-dict branch from e533ea1 to 37919b9 Compare May 10, 2023 14:50
@MaineK00n MaineK00n marked this pull request as ready for review May 10, 2023 14:56
@MaineK00n
Copy link
Collaborator Author

$ make diff
# git clone git@github.com:vulsio/vulsctl.git
# cd vulsctl/docker
# ./update-all.sh
# cd /path/to/vuls
# vim integration/int-config.toml
# ln -s vuls vuls.new
# ln -s oldvuls vuls.old
# make int
mkdir -p ''/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results'/2023-05-11T00-10-54+0900'
sleep 1
# ./vuls.old scan -config=./integration/int-config.toml --results-dir='/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results' 'bundler' 'pip' 'pipenv' 'poetry' 'composer' 'npm' 'yarn' 'pnpm' 'cargo' 'gomod' 'gosum' 'gobinary' 'jar' 'pom' 'gradle' 'nuget-lock' 'nuget-config' 'dotnet-deps' 'conan' 'nvd_exact' 'nvd_rough' 'nvd_vendor_product' 'nvd_match_no_jvn' 'jvn_vendor_product' 'jvn_vendor_product_nover'
# cp '/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results'/`find '/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results' -type d  -exec basename {} \; | sort -nr | head -n 1`/*.json ''/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results'/2023-05-11T00-10-54+0900'
cp integration/data/results/*.json ''/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results'/2023-05-11T00-10-54+0900'
./vuls.old report --format-json --refresh-cve --results-dir='/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results' -config=./integration/int-config.toml 2023-05-11T00-10-54+0900
[May 11 00:10:55]  INFO [localhost] vuls-v0.23.1-build-20230510_235719_ef80838
...
mkdir -p ''/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results'/2023-05-11T00-10-55+0900'
sleep 1
# ./vuls.new scan -config=./integration/int-config.toml --results-dir='/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results' 'bundler' 'pip' 'pipenv' 'poetry' 'composer' 'npm' 'yarn' 'pnpm' 'cargo' 'gomod' 'gosum' 'gobinary' 'jar' 'pom' 'gradle' 'nuget-lock' 'nuget-config' 'dotnet-deps' 'conan' 'nvd_exact' 'nvd_rough' 'nvd_vendor_product' 'nvd_match_no_jvn' 'jvn_vendor_product' 'jvn_vendor_product_nover'
# cp '/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results'/`find '/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results' -type d  -exec basename {} \; | sort -nr | head -n 1`/*.json ''/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results'/2023-05-11T00-10-55+0900'
cp integration/data/results/*.json ''/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results'/2023-05-11T00-10-55+0900'
./vuls.new report --format-json --refresh-cve --results-dir='/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results' -config=./integration/int-config.toml 2023-05-11T00-10-55+0900
[May 11 00:11:24]  INFO [localhost] vuls-v0.23.1-build-20230510_235857_37919b9
...
find ''/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results'/2023-05-11T00-10-54+0900' -type f -exec sed -i -e '/scannedAt/d' {} \;
find ''/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results'/2023-05-11T00-10-55+0900' -type f -exec sed -i -e '/scannedAt/d' {} \;
find ''/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results'/2023-05-11T00-10-54+0900' -type f -exec sed -i -e '/reportedAt/d' {} \;
find ''/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results'/2023-05-11T00-10-55+0900' -type f -exec sed -i -e '/reportedAt/d' {} \;
find ''/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results'/2023-05-11T00-10-54+0900' -type f -exec sed -i -e '/"Type":/d' {} \;
find ''/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results'/2023-05-11T00-10-55+0900' -type f -exec sed -i -e '/"Type":/d' {} \;
find ''/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results'/2023-05-11T00-10-54+0900' -type f -exec sed -i -e '/"SQLite3Path":/d' {} \;
find ''/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results'/2023-05-11T00-10-55+0900' -type f -exec sed -i -e '/"SQLite3Path":/d' {} \;
find ''/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results'/2023-05-11T00-10-54+0900' -type f -exec sed -i -e '/reportedRevision/d' {} \;
find ''/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results'/2023-05-11T00-10-55+0900' -type f -exec sed -i -e '/reportedRevision/d' {} \;
find ''/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results'/2023-05-11T00-10-54+0900' -type f -exec sed -i -e '/scannedRevision/d' {} \;
find ''/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results'/2023-05-11T00-10-55+0900' -type f -exec sed -i -e '/scannedRevision/d' {} \;
diff -c ''/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results'/2023-05-11T00-10-54+0900' ''/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results'/2023-05-11T00-10-55+0900'
echo "old: ''/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results'/2023-05-11T00-10-54+0900' , new: ''/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results'/2023-05-11T00-10-55+0900'"
old: ''/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results'/2023-05-11T00-10-54+0900' , new: ''/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results'/2023-05-11T00-10-55+0900'
for jsonfile in ''/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results'/2023-05-11T00-10-54+0900'/*.json ;  do echo $jsonfile; cat $jsonfile | jq ".scannedCves | length" ; done
/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results/2023-05-11T00-10-54+0900/amazon_2.json
508
/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results/2023-05-11T00-10-54+0900/centos_7.json
407
/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results/2023-05-11T00-10-54+0900/debian_10.json
658
/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results/2023-05-11T00-10-54+0900/debian_11.json
931
/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results/2023-05-11T00-10-54+0900/debian_9.json
0
/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results/2023-05-11T00-10-54+0900/leap.json
527
/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results/2023-05-11T00-10-54+0900/localhost.json
419
/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results/2023-05-11T00-10-54+0900/oracle.json
206
/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results/2023-05-11T00-10-54+0900/rhel_610.json
187
/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results/2023-05-11T00-10-54+0900/rhel_73.json
977
/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results/2023-05-11T00-10-54+0900/rhel_80.json
1073
/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results/2023-05-11T00-10-54+0900/rhel_90.json
372
/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results/2023-05-11T00-10-54+0900/sles12.json
557
/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results/2023-05-11T00-10-54+0900/sles15.json
674
/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results/2023-05-11T00-10-54+0900/ubuntu_1404.json
2
/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results/2023-05-11T00-10-54+0900/ubuntu_1604.json
2
/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results/2023-05-11T00-10-54+0900/ubuntu_1804.json
204
/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results/2023-05-11T00-10-54+0900/ubuntu_2004.json
266
/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results/2023-05-11T00-10-54+0900/ubuntu_2204.json
190
/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results/2023-05-11T00-10-54+0900/windows.json
0
for jsonfile in ''/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results'/2023-05-11T00-10-55+0900'/*.json ;  do echo $jsonfile; cat $jsonfile | jq ".scannedCves | length" ; done
/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results/2023-05-11T00-10-55+0900/amazon_2.json
508
/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results/2023-05-11T00-10-55+0900/centos_7.json
407
/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results/2023-05-11T00-10-55+0900/debian_10.json
658
/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results/2023-05-11T00-10-55+0900/debian_11.json
931
/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results/2023-05-11T00-10-55+0900/debian_9.json
0
/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results/2023-05-11T00-10-55+0900/leap.json
527
/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results/2023-05-11T00-10-55+0900/localhost.json
419
/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results/2023-05-11T00-10-55+0900/oracle.json
206
/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results/2023-05-11T00-10-55+0900/rhel_610.json
187
/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results/2023-05-11T00-10-55+0900/rhel_73.json
977
/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results/2023-05-11T00-10-55+0900/rhel_80.json
1073
/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results/2023-05-11T00-10-55+0900/rhel_90.json
372
/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results/2023-05-11T00-10-55+0900/sles12.json
557
/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results/2023-05-11T00-10-55+0900/sles15.json
674
/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results/2023-05-11T00-10-55+0900/ubuntu_1404.json
2
/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results/2023-05-11T00-10-55+0900/ubuntu_1604.json
2
/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results/2023-05-11T00-10-55+0900/ubuntu_1804.json
204
/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results/2023-05-11T00-10-55+0900/ubuntu_2004.json
266
/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results/2023-05-11T00-10-55+0900/ubuntu_2204.json
190
/home/mainek00n/github/github.com/MaineK00n/vuls/integration/results/2023-05-11T00-10-55+0900/windows.json
0

@MaineK00n MaineK00n merged commit 7475b27 into master May 10, 2023
@MaineK00n MaineK00n deleted the MaineK00n/update-dict branch May 10, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant