feat(detector/library): update JAR-like files' Name/Version in library list #1874
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Before this pull request, JAR-like files' names and versions are partially correct and partially wrong, beause correction by Trivy's Java DB is performed in
vuls report
phase.For example, one entry in "libraries" list of scan result looks like below
and libraryFixedIns of
vuls report
resultIt's not easy to find what is the current version of a library in libraryFixedIns.
Furthermore, there can be more broken names like:
This overwrite of Name's and Version's does not conserve the input of
vuls report
as is.But these entries are not trusted from the first. Only trusted entry is Digest's.
(If there is no Digest field, Name and version are trusted and not overwritten)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
vuls report
does not changevuls report
library list is updated by the help of Java DBName's before report
Name's after report
Checklist:
You don't have to satisfy all of the following.
make fmt
make test
Is this ready for review?: Yes