Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(log): saas s3 upload error log #1966

Merged

Conversation

future-ryunosuketanai
Copy link
Contributor

What did you implement:

Updated to log the correct object name in the saas report log when an error occurs with an s3 upload.

Type of change

Please delete options that are not relevant.

  • Only change s3 upload error log

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

@MaineK00n MaineK00n requested a review from shino June 17, 2024 06:46
@future-ryunosuketanai future-ryunosuketanai marked this pull request as ready for review June 17, 2024 06:48
Copy link
Collaborator

@shino shino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

@shino shino merged commit ad4f66d into future-architect:master Jun 17, 2024
7 checks passed
@future-ryunosuketanai future-ryunosuketanai deleted the saas/s3upload-errorlog branch June 17, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants