Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(detector/microsoft): set WindowsRoughMatch if KB or Version to be fixed is unknown #2041

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

MaineK00n
Copy link
Collaborator

@MaineK00n MaineK00n commented Oct 2, 2024

If this Pull Request is work in progress, Add a prefix of “[WIP]” in the title.

What did you implement:

Among the vulnerabilities detected in Windows, particularly in Edge, even those for which the KB or fixed build to fix them is unknown are set with a confidence level of 100, called WindowsUpdateSearch.
Because cases like this are very noisy, we set WindowsRoughMatch, which lowers the reliability to 30.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

before

$ vuls report --refresh-cve
$ cat results/2024-10-04T02-18-44+0900/localhost.json | jq '.scannedCves."CVE-2023-6112" | [.confidences,.affectedPackages]'
[
  [
    {
      "score": 100,
      "detectionMethod": "WindowsUpdateSearch"
    }
  ],
  [
    {
      "name": "Microsoft Edge",
      "fixState": "unknown"
    }
  ]
]

after

$ vuls report --refresh-cve
$ cat results/2024-10-04T02-18-44+0900/localhost.json | jq '.scannedCves."CVE-2023-6112" | [.confidences,.affectedPackages]'
[
  [
    {
      "score": 30,
      "detectionMethod": "WindowsRoughMatch"
    }
  ],
  [
    {
      "name": "Microsoft Edge",
      "fixState": "unknown"
    }
  ]
]

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

Reference

@MaineK00n MaineK00n self-assigned this Oct 2, 2024
@MaineK00n MaineK00n changed the title Maine k00n/microsoft feat(detector/microsoft): set WindowsRoughMatch if KB or Version to be fixed is unknown Oct 2, 2024
@MaineK00n MaineK00n force-pushed the MaineK00n/microsoft branch 3 times, most recently from 0bdcca8 to ee6cd80 Compare October 3, 2024 18:10
@MaineK00n MaineK00n changed the title feat(detector/microsoft): set WindowsRoughMatch if KB or Version to be fixed is unknown feat!(detector/microsoft): set WindowsRoughMatch if KB or Version to be fixed is unknown Oct 3, 2024
@MaineK00n MaineK00n changed the title feat!(detector/microsoft): set WindowsRoughMatch if KB or Version to be fixed is unknown feat(detector/microsoft): set WindowsRoughMatch if KB or Version to be fixed is unknown Oct 3, 2024
@MaineK00n MaineK00n marked this pull request as ready for review October 3, 2024 18:29
@MaineK00n MaineK00n requested a review from shino October 3, 2024 18:29
gost/microsoft.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@shino shino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!!

@MaineK00n MaineK00n merged commit 3dd738d into master Oct 8, 2024
7 checks passed
@MaineK00n MaineK00n deleted the MaineK00n/microsoft branch October 8, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants