Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contrib/snmp2cpe): add --port/-P option #2046

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Conversation

MaineK00n
Copy link
Collaborator

If this Pull Request is work in progress, Add a prefix of “[WIP]” in the title.

What did you implement:

add --port/-P option to snmp2cpe command

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

$ git clone https://github.com/MaineK00n/vuls-targets.git
$ docker build -t vuls-target:snmp -f vuls-targets/snmp/Dockerfile .
$ docker run --rm -itd -p 1611:161/udp --name vuls-target vuls-target:snmp

$ make build-snmp2cpe
$ snmp2cpe v2c --port 1611 127.0.0.1 juniper-mx960-13-3r9-13 | snmp2cpe convert
{"127.0.0.1":["cpe:2.3:h:juniper:mx960:-:*:*:*:*:*:*:*","cpe:2.3:o:juniper:junos:13.3r9.13:*:*:*:*:*:*:*"]}

Checklist:

You don't have to satisfy all of the following.

  • Write tests
  • Write documentation
  • Check that there aren't other open pull requests for the same issue/feature
  • Format your source code by make fmt
  • Pass the test by make test
  • Provide verification config / commands
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES

Reference

@MaineK00n MaineK00n self-assigned this Oct 10, 2024
@MaineK00n MaineK00n requested a review from shino October 10, 2024 02:37
Copy link
Collaborator

@shino shino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎊

@MaineK00n MaineK00n merged commit 2c51bcf into master Oct 10, 2024
7 checks passed
@MaineK00n MaineK00n deleted the MaineK00n/patch-1 branch October 10, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants