Add the XML output #240
Merged
Add the XML output #240
+92
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please fix glide.lock |
gleentea
force-pushed
the
feature/report-xml
branch
2 times, most recently
from
2dfb2f5 to
5f6d806
Compare
kotakanbe
requested changes
Nov 3, 2016
| ) | ||
|
|
||
| const ( | ||
| VulsOpenTag = "<vulsreport>" |
There was a problem hiding this comment.
Please change const name to vulsOpenTag, vulsCloseTag
Lint error is Occurred.
➜ vuls git:(xml) make lint
report/xml.go:15:2: exported const VulsOpenTag should have comment (or a comment on this block) or be unexported
| ) | ||
|
|
||
| // XMLDirs array of xml files path. | ||
| type XMLDirs []string |
There was a problem hiding this comment.
XML Dirs is unused.
Please remove this.
| return fmt.Errorf("Failed to Marshal to XML: %s", err) | ||
| } | ||
|
|
||
| allBytes := bytes.Join([][]byte{[]byte(xml.Header + VulsOpenTag), xmlBytes, []byte(VulsCloseTag)},[]byte{}) |
There was a problem hiding this comment.
Please apply go fmt to format this source code.
$ cd /path/to/vuls
$ make fmt
| @@ -700,11 +703,11 @@ Defaults:vuls !requiretty | |||
| | empty password | - | | | |||
| | with password | required | or use ssh-agent | | |||
|
|
|||
| ## -report-json , -report-text option | |||
| ## -report-json , -report-text , -report-xml option | |||
|
|
|||
| 結果をファイルに出力したい場合に指定する。出力先は、`$PWD/result/current/` | |||
| `all.(json|txt)`には、全サーバのスキャン結果が出力される。 | |||
There was a problem hiding this comment.
すみません、all.jsonは廃止されたので、all.jsonの下りを削除していただけますか。（私の修正漏れです）
|
|
||
| At the end of the scan, scan results will be available in the `$PWD/result/current/` directory. | ||
| `all.(json|txt)` includes the scan results of all servers and `servername.(json|txt)` includes the scan result of the server. | ||
| `all.(json|txt)` includes the scan results of all servers and `servername.(json|txt|xml)` includes the scan result of the server. |
There was a problem hiding this comment.
all.json no kudari wo keshite kudasai
add struct tag for encoding/xml update README update glide.lock
gleentea
force-pushed
the
feature/report-xml
branch
from
5f6d806 to
ce2daf2
Compare
|
I applied golint/gofmt and update README. |
kotakanbe
approved these changes
Nov 7, 2016
|
LGTM :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the XML output in order to facilitate cooperation with other tools.