New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PULL_REQUEST_TEMPLATE.md #348

Merged

kotakanbe merged 1 commit into future-architect:master from knqyf263:add_template

Feb 20, 2017

Contributor

knqyf263 commented Feb 19, 2017 •

edited

Loading

What did you implement:

Add PULL_REQUEST_TEMPLATE.md

How did you implement it:

I referred to the following repository.
https://github.com/serverless/serverless/blob/master/.github/PULL_REQUEST_TEMPLATE.md
https://github.com/Homebrew/homebrew-core/blob/master/.github/PULL_REQUEST_TEMPLATE.md

How can we verify it:

Create Pull Request.

Todos:

Write tests
Write documentation
Check that there aren't other open pull requests for the same issue/feature
Format your source code by make fmt
Pass the test by make test
Provide verification config / commands
Enable "Allow edits from maintainers" for this PR
Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO


          Add PULL_REQUEST_TEMPLATE.md

851cecd

kotakanbe merged commit 1419c7c into future-architect:master

Member

kotakanbe commented Feb 20, 2017

Many Thanks!

knqyf263 deleted the add_template branch

February 20, 2017 06:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet