Enable -timeout option when detecting OS #410
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
I got the following error.
The timeout for detecting server OS is hard coded to 30 seconds.
https://github.com/future-architect/vuls/blob/master/scan/serverapi.go#L156
https://github.com/future-architect/vuls/blob/master/scan/serverapi.go#L218
I fixed this.
How did you implement it:
For
configtest
,-timeout
option has already implemented, so I used it.For
scan
, I added-timeout
option.How can we verify it:
Todos:
You don't have to satisfy all of the following.
make fmt
make test
Is this ready for review?: YES
Is it a breaking change?: NO