Change default ssh method from go library to external command #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knqyf263
suggested changes
Apr 5, 2017
config/config.go
Outdated
| if runtime.GOOS == "windows" && c.SSHExternal { | ||
| errs = append(errs, fmt.Errorf("-ssh-external cannot be used on windows")) | ||
| if runtime.GOOS == "windows" && !c.SSHNative { | ||
| errs = append(errs, fmt.Errorf("-ssh-native is needed on windows")) |
There was a problem hiding this comment.
-ssh-native → -ssh-native-insecure
README.md
Outdated
| This is useful If you want to use ProxyCommand or cipher algorithm of SSH that is not supported by native go implementation. | ||
| Don't forget to add below line to /etc/sudoers on the target servers. (username: vuls) | ||
| ``` | ||
| Defaults:vuls !requiretty | ||
| ``` | ||
|
|
||
| To use native Go implementation from crypto/ssh, specify this option. | ||
| This is useful in situations where you may not have access to traditional UNIX tools. | ||
| But It is important to note that this mode does not check the host key. |
knqyf263
approved these changes
Apr 6, 2017
lapthorn
pushed a commit
to lapthorn/vuls
that referenced
this pull request
May 11, 2017
…-architect#416) * Change default ssh method from go library to external command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Closes #415
How did you implement it:
Remove ssh-external option.
Add ssh-native-insecure option.
How can we verify it:
Run Vuls with/without this option.
Todos:
You don't have to satisfy all of the following.
make fmtmake testIs this ready for review?: YES
Is it a breaking change?: YES