Skip to content
This repository has been archived by the owner on Oct 14, 2022. It is now read-only.

DELETE endpoints return the deleted item, they should return 204 No Content #26

Closed
dalbitresb12 opened this issue Jun 27, 2022 · 1 comment · Fixed by #29
Closed

DELETE endpoints return the deleted item, they should return 204 No Content #26

dalbitresb12 opened this issue Jun 27, 2022 · 1 comment · Fixed by #29
Assignees
@amenes12
Labels
bug Something isn't working
Milestone
Sprint 5

Comments

@dalbitresb12
Copy link
Contributor

Bug report

Describe the bug

Currently, DELETE endpoints return the item that was just deleted. That is a bug and they should return an empty body with status code 204 No Content

Steps to reproduce the behavior

  1. Send a request to any DELETE endpoint
  2. See the content deleted be returned in the response body

Expected behavior

204 No Content should be returned.
@dalbitresb12 dalbitresb12 added the bug Something isn't working label Jun 27, 2022
@dalbitresb12 dalbitresb12 added this to the Sprint 5 milestone Jun 27, 2022
@dalbitresb12 dalbitresb12 linked a pull request Jun 28, 2022 that will close this issue
fix: Delete response #29
Merged
@dalbitresb12 dalbitresb12 mentioned this issue Jun 28, 2022
Merged
@dalbitresb12
Copy link
Contributor Author

Don't know why it didn't close automatically on merge.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@amenes12 amenes12

Labels
bug Something isn't working
Projects
None yet
Milestone
Sprint 5
Development

Successfully merging a pull request may close this issue.

fix: Delete response futureleadersupc/waw-backend-cs
2 participants
@dalbitresb12 @amenes12