Skip to content
This repository has been archived by the owner on Oct 14, 2022. It is now read-only.

fix: Delete response #29

Merged
merged 3 commits into from
Jun 28, 2022
Merged

fix: Delete response #29

merged 3 commits into from
Jun 28, 2022

Conversation

amenes12
Copy link
Contributor

@amenes12 amenes12 commented Jun 28, 2022 •
edited by dalbitresb12
Loading

What does it do

Changed the delete response to an No Content with status code 204.

Why is it needed

When a delete request is sent, is not a good practice to show the resource in the response body. We want to make the client know that the item was deleted successfully and is no longer available.

Related issue(s)/PR(s)

Fixes #26.

@amenes12 amenes12 added bug Something isn't working documentation Improvements or additions to documentation labels Jun 28, 2022
@amenes12 amenes12 added this to the Sprint 5 milestone Jun 28, 2022
@amenes12 amenes12 self-assigned this Jun 28, 2022
@amenes12 amenes12 changed the base branch from main to develop June 28, 2022 00:51
@dalbitresb12-bot
Copy link

dalbitresb12-bot commented Jun 28, 2022 •
edited
Loading

Test Results  :heavy_check_mark: 

Tests: 5 passed

5 tests were completed in 5707ms, with 5 passed, 0 failed and 0 skipped.

Deploying LivingDoc with  Cloudflare Pages  Cloudflare Pages

Latest commit:ff38f8c
Status: :white_check_mark:  Deploy successful!
Preview URL:https://9f7e654a.waw-backend-cs-livingdoc.pages.dev
 View logs
Diagnostic Information: What the bot saw about this commit
{
  "testReport": {
    "conclusion": "success",
    "passed": 5,
    "failed": 0,
    "skipped": 0,
    "time": 5707
  },
  "deployment": {
    "id": "9f7e654a-ea23-4008-8dbb-183e021568f8",
    "url": "https://9f7e654a.waw-backend-cs-livingdoc.pages.dev",
    "environment": "production",
    "projectName": "waw-backend-cs-livingdoc",
    "logsUrl": "https://dash.cloudflare.com/?to=/:account/pages/view/waw-backend-cs-livingdoc/9f7e654a-ea23-4008-8dbb-183e021568f8"
  },
  "runInfo": {
    "sourceHeadRepo": "futureleadersupc/waw-backend-cs",
    "sourceHeadBranch": "fix/delete-response",
    "sourceHeadSha": "65a1f1681ae7adee8de6a89b97e702d23b7d7ea1",
    "sourceEvent": "pull_request",
    "pullRequestNumber": "29",
    "pullRequestLabels": "[\"bug\",\"documentation\"]",
    "mergeCommitSha": "ff38f8c80fda6a298c7d9b260008a67311502300",
    "targetCommitSha": "ff38f8c80fda6a298c7d9b260008a67311502300",
    "targetBranch": "develop"
  },
  "context": {
    "payload": {
      "action": "completed",
      "organization": {
        "avatar_url": "https://avatars.githubusercontent.com/u/104031056?v=4",
        "description": "Academic work carried out for the courses of Web Applications and Open-Source Applications of Universidad Peruana de Ciencias Aplicadas (UPC)",
        "events_url": "https://api.github.com/orgs/futureleadersupc/events",
        "hooks_url": "https://api.github.com/orgs/futureleadersupc/hooks",
        "id": 104031056,
        "issues_url": "https://api.github.com/orgs/futureleadersupc/issues",
        "login": "futureleadersupc",
        "members_url": "https://api.github.com/orgs/futureleadersupc/members{/member}",
        "node_id": "O_kgDOBjNjUA",
        "public_members_url": "https://api.github.com/orgs/futureleadersupc/public_members{/member}",
        "repos_url": "https://api.github.com/orgs/futureleadersupc/repos",
        "url": "https://api.github.com/orgs/futureleadersupc"
      },
      "repository": {
        "allow_forking": true,
        "archive_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/{archive_format}{/ref}",
        "archived": false,
        "assignees_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/assignees{/user}",
        "blobs_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/git/blobs{/sha}",
        "branches_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/branches{/branch}",
        "clone_url": "https://github.com/futureleadersupc/waw-backend-cs.git",
        "collaborators_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/collaborators{/collaborator}",
        "comments_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/comments{/number}",
        "commits_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/commits{/sha}",
        "compare_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/compare/{base}...{head}",
        "contents_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/contents/{+path}",
        "contributors_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/contributors",
        "created_at": "2022-05-17T19:03:23Z",
        "default_branch": "main",
        "deployments_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/deployments",
        "description": "WAW Backend Application, using C# and ASP.NET Core",
        "disabled": false,
        "downloads_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/downloads",
        "events_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/events",
        "fork": false,
        "forks": 0,
        "forks_count": 0,
        "forks_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/forks",
        "full_name": "futureleadersupc/waw-backend-cs",
        "git_commits_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/git/commits{/sha}",
        "git_refs_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/git/refs{/sha}",
        "git_tags_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/git/tags{/sha}",
        "git_url": "git://github.com/futureleadersupc/waw-backend-cs.git",
        "has_downloads": true,
        "has_issues": true,
        "has_pages": false,
        "has_projects": true,
        "has_wiki": true,
        "homepage": "",
        "hooks_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/hooks",
        "html_url": "https://github.com/futureleadersupc/waw-backend-cs",
        "id": 493379817,
        "is_template": false,
        "issue_comment_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/issues/comments{/number}",
        "issue_events_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/issues/events{/number}",
        "issues_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/issues{/number}",
        "keys_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/keys{/key_id}",
        "labels_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/labels{/name}",
        "language": "C#",
        "languages_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/languages",
        "license": {
          "key": "mit",
          "name": "MIT License",
          "node_id": "MDc6TGljZW5zZTEz",
          "spdx_id": "MIT",
          "url": "https://api.github.com/licenses/mit"
        },
        "merges_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/merges",
        "milestones_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/milestones{/number}",
        "mirror_url": null,
        "name": "waw-backend-cs",
        "node_id": "R_kgDOHWhg6Q",
        "notifications_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/notifications{?since,all,participating}",
        "open_issues": 4,
        "open_issues_count": 4,
        "owner": {
          "avatar_url": "https://avatars.githubusercontent.com/u/104031056?v=4",
          "events_url": "https://api.github.com/users/futureleadersupc/events{/privacy}",
          "followers_url": "https://api.github.com/users/futureleadersupc/followers",
          "following_url": "https://api.github.com/users/futureleadersupc/following{/other_user}",
          "gists_url": "https://api.github.com/users/futureleadersupc/gists{/gist_id}",
          "gravatar_id": "",
          "html_url": "https://github.com/futureleadersupc",
          "id": 104031056,
          "login": "futureleadersupc",
          "node_id": "O_kgDOBjNjUA",
          "organizations_url": "https://api.github.com/users/futureleadersupc/orgs",
          "received_events_url": "https://api.github.com/users/futureleadersupc/received_events",
          "repos_url": "https://api.github.com/users/futureleadersupc/repos",
          "site_admin": false,
          "starred_url": "https://api.github.com/users/futureleadersupc/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/futureleadersupc/subscriptions",
          "type": "Organization",
          "url": "https://api.github.com/users/futureleadersupc"
        },
        "private": false,
        "pulls_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/pulls{/number}",
        "pushed_at": "2022-06-28T03:15:00Z",
        "releases_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/releases{/id}",
        "size": 399,
        "ssh_url": "git@github.com:futureleadersupc/waw-backend-cs.git",
        "stargazers_count": 0,
        "stargazers_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/stargazers",
        "statuses_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/statuses/{sha}",
        "subscribers_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/subscribers",
        "subscription_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/subscription",
        "svn_url": "https://github.com/futureleadersupc/waw-backend-cs",
        "tags_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/tags",
        "teams_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/teams",
        "topics": [],
        "trees_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/git/trees{/sha}",
        "updated_at": "2022-06-24T16:18:34Z",
        "url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs",
        "visibility": "public",
        "watchers": 0,
        "watchers_count": 0
      },
      "sender": {
        "avatar_url": "https://avatars.githubusercontent.com/u/64373189?v=4",
        "events_url": "https://api.github.com/users/amenes12/events{/privacy}",
        "followers_url": "https://api.github.com/users/amenes12/followers",
        "following_url": "https://api.github.com/users/amenes12/following{/other_user}",
        "gists_url": "https://api.github.com/users/amenes12/gists{/gist_id}",
        "gravatar_id": "",
        "html_url": "https://github.com/amenes12",
        "id": 64373189,
        "login": "amenes12",
        "node_id": "MDQ6VXNlcjY0MzczMTg5",
        "organizations_url": "https://api.github.com/users/amenes12/orgs",
        "received_events_url": "https://api.github.com/users/amenes12/received_events",
        "repos_url": "https://api.github.com/users/amenes12/repos",
        "site_admin": false,
        "starred_url": "https://api.github.com/users/amenes12/starred{/owner}{/repo}",
        "subscriptions_url": "https://api.github.com/users/amenes12/subscriptions",
        "type": "User",
        "url": "https://api.github.com/users/amenes12"
      },
      "workflow": {
        "badge_url": "https://github.com/futureleadersupc/waw-backend-cs/workflows/.NET/badge.svg",
        "created_at": "2022-06-07T08:57:48.000Z",
        "html_url": "https://github.com/futureleadersupc/waw-backend-cs/blob/main/.github/workflows/dotnet.yml",
        "id": 27661483,
        "name": ".NET",
        "node_id": "W_kwDOHWhg6c4BphSr",
        "path": ".github/workflows/dotnet.yml",
        "state": "active",
        "updated_at": "2022-06-07T08:57:48.000Z",
        "url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/actions/workflows/27661483"
      },
      "workflow_run": {
        "actor": {
          "avatar_url": "https://avatars.githubusercontent.com/u/64373189?v=4",
          "events_url": "https://api.github.com/users/amenes12/events{/privacy}",
          "followers_url": "https://api.github.com/users/amenes12/followers",
          "following_url": "https://api.github.com/users/amenes12/following{/other_user}",
          "gists_url": "https://api.github.com/users/amenes12/gists{/gist_id}",
          "gravatar_id": "",
          "html_url": "https://github.com/amenes12",
          "id": 64373189,
          "login": "amenes12",
          "node_id": "MDQ6VXNlcjY0MzczMTg5",
          "organizations_url": "https://api.github.com/users/amenes12/orgs",
          "received_events_url": "https://api.github.com/users/amenes12/received_events",
          "repos_url": "https://api.github.com/users/amenes12/repos",
          "site_admin": false,
          "starred_url": "https://api.github.com/users/amenes12/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/amenes12/subscriptions",
          "type": "User",
          "url": "https://api.github.com/users/amenes12"
        },
        "artifacts_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/actions/runs/2573494098/artifacts",
        "cancel_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/actions/runs/2573494098/cancel",
        "check_suite_id": 7118839720,
        "check_suite_node_id": "CS_kwDOHWhg6c8AAAABqFDfqA",
        "check_suite_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/check-suites/7118839720",
        "conclusion": "success",
        "created_at": "2022-06-28T03:15:04Z",
        "event": "pull_request",
        "head_branch": "fix/delete-response",
        "head_commit": {
          "author": {
            "email": "angelmenesest123@gmail.com",
            "name": "Ángel Meneses"
          },
          "committer": {
            "email": "noreply@github.com",
            "name": "GitHub"
          },
          "id": "65a1f1681ae7adee8de6a89b97e702d23b7d7ea1",
          "message": "fix: minero changes",
          "timestamp": "2022-06-28T03:14:59Z",
          "tree_id": "086380354c7b1ea069120e749d4b96f3ebfa6d9b"
        },
        "head_repository": {
          "archive_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/{archive_format}{/ref}",
          "assignees_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/assignees{/user}",
          "blobs_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/git/blobs{/sha}",
          "branches_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/branches{/branch}",
          "collaborators_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/collaborators{/collaborator}",
          "comments_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/comments{/number}",
          "commits_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/commits{/sha}",
          "compare_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/compare/{base}...{head}",
          "contents_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/contents/{+path}",
          "contributors_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/contributors",
          "deployments_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/deployments",
          "description": "WAW Backend Application, using C# and ASP.NET Core",
          "downloads_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/downloads",
          "events_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/events",
          "fork": false,
          "forks_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/forks",
          "full_name": "futureleadersupc/waw-backend-cs",
          "git_commits_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/git/commits{/sha}",
          "git_refs_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/git/refs{/sha}",
          "git_tags_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/git/tags{/sha}",
          "hooks_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/hooks",
          "html_url": "https://github.com/futureleadersupc/waw-backend-cs",
          "id": 493379817,
          "issue_comment_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/issues/comments{/number}",
          "issue_events_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/issues/events{/number}",
          "issues_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/issues{/number}",
          "keys_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/keys{/key_id}",
          "labels_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/labels{/name}",
          "languages_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/languages",
          "merges_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/merges",
          "milestones_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/milestones{/number}",
          "name": "waw-backend-cs",
          "node_id": "R_kgDOHWhg6Q",
          "notifications_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/notifications{?since,all,participating}",
          "owner": {
            "avatar_url": "https://avatars.githubusercontent.com/u/104031056?v=4",
            "events_url": "https://api.github.com/users/futureleadersupc/events{/privacy}",
            "followers_url": "https://api.github.com/users/futureleadersupc/followers",
            "following_url": "https://api.github.com/users/futureleadersupc/following{/other_user}",
            "gists_url": "https://api.github.com/users/futureleadersupc/gists{/gist_id}",
            "gravatar_id": "",
            "html_url": "https://github.com/futureleadersupc",
            "id": 104031056,
            "login": "futureleadersupc",
            "node_id": "O_kgDOBjNjUA",
            "organizations_url": "https://api.github.com/users/futureleadersupc/orgs",
            "received_events_url": "https://api.github.com/users/futureleadersupc/received_events",
            "repos_url": "https://api.github.com/users/futureleadersupc/repos",
            "site_admin": false,
            "starred_url": "https://api.github.com/users/futureleadersupc/starred{/owner}{/repo}",
            "subscriptions_url": "https://api.github.com/users/futureleadersupc/subscriptions",
            "type": "Organization",
            "url": "https://api.github.com/users/futureleadersupc"
          },
          "private": false,
          "pulls_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/pulls{/number}",
          "releases_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/releases{/id}",
          "stargazers_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/stargazers",
          "statuses_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/statuses/{sha}",
          "subscribers_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/subscribers",
          "subscription_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/subscription",
          "tags_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/tags",
          "teams_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/teams",
          "trees_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/git/trees{/sha}",
          "url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs"
        },
        "head_sha": "65a1f1681ae7adee8de6a89b97e702d23b7d7ea1",
        "html_url": "https://github.com/futureleadersupc/waw-backend-cs/actions/runs/2573494098",
        "id": 2573494098,
        "jobs_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/actions/runs/2573494098/jobs",
        "logs_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/actions/runs/2573494098/logs",
        "name": ".NET",
        "node_id": "WFR_kwLOHWhg6c6ZZGdS",
        "path": ".github/workflows/dotnet.yml",
        "previous_attempt_url": null,
        "pull_requests": [
          {
            "base": {
              "ref": "develop",
              "repo": {
                "id": 493379817,
                "name": "waw-backend-cs",
                "url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs"
              },
              "sha": "764570b46cdc28b04a85311de4fdcbe8d176a1b0"
            },
            "head": {
              "ref": "fix/delete-response",
              "repo": {
                "id": 493379817,
                "name": "waw-backend-cs",
                "url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs"
              },
              "sha": "65a1f1681ae7adee8de6a89b97e702d23b7d7ea1"
            },
            "id": 980779824,
            "number": 29,
            "url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/pulls/29"
          }
        ],
        "referenced_workflows": [],
        "repository": {
          "archive_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/{archive_format}{/ref}",
          "assignees_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/assignees{/user}",
          "blobs_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/git/blobs{/sha}",
          "branches_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/branches{/branch}",
          "collaborators_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/collaborators{/collaborator}",
          "comments_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/comments{/number}",
          "commits_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/commits{/sha}",
          "compare_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/compare/{base}...{head}",
          "contents_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/contents/{+path}",
          "contributors_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/contributors",
          "deployments_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/deployments",
          "description": "WAW Backend Application, using C# and ASP.NET Core",
          "downloads_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/downloads",
          "events_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/events",
          "fork": false,
          "forks_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/forks",
          "full_name": "futureleadersupc/waw-backend-cs",
          "git_commits_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/git/commits{/sha}",
          "git_refs_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/git/refs{/sha}",
          "git_tags_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/git/tags{/sha}",
          "hooks_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/hooks",
          "html_url": "https://github.com/futureleadersupc/waw-backend-cs",
          "id": 493379817,
          "issue_comment_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/issues/comments{/number}",
          "issue_events_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/issues/events{/number}",
          "issues_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/issues{/number}",
          "keys_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/keys{/key_id}",
          "labels_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/labels{/name}",
          "languages_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/languages",
          "merges_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/merges",
          "milestones_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/milestones{/number}",
          "name": "waw-backend-cs",
          "node_id": "R_kgDOHWhg6Q",
          "notifications_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/notifications{?since,all,participating}",
          "owner": {
            "avatar_url": "https://avatars.githubusercontent.com/u/104031056?v=4",
            "events_url": "https://api.github.com/users/futureleadersupc/events{/privacy}",
            "followers_url": "https://api.github.com/users/futureleadersupc/followers",
            "following_url": "https://api.github.com/users/futureleadersupc/following{/other_user}",
            "gists_url": "https://api.github.com/users/futureleadersupc/gists{/gist_id}",
            "gravatar_id": "",
            "html_url": "https://github.com/futureleadersupc",
            "id": 104031056,
            "login": "futureleadersupc",
            "node_id": "O_kgDOBjNjUA",
            "organizations_url": "https://api.github.com/users/futureleadersupc/orgs",
            "received_events_url": "https://api.github.com/users/futureleadersupc/received_events",
            "repos_url": "https://api.github.com/users/futureleadersupc/repos",
            "site_admin": false,
            "starred_url": "https://api.github.com/users/futureleadersupc/starred{/owner}{/repo}",
            "subscriptions_url": "https://api.github.com/users/futureleadersupc/subscriptions",
            "type": "Organization",
            "url": "https://api.github.com/users/futureleadersupc"
          },
          "private": false,
          "pulls_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/pulls{/number}",
          "releases_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/releases{/id}",
          "stargazers_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/stargazers",
          "statuses_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/statuses/{sha}",
          "subscribers_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/subscribers",
          "subscription_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/subscription",
          "tags_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/tags",
          "teams_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/teams",
          "trees_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/git/trees{/sha}",
          "url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs"
        },
        "rerun_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/actions/runs/2573494098/rerun",
        "run_attempt": 1,
        "run_number": 86,
        "run_started_at": "2022-06-28T03:15:04Z",
        "status": "completed",
        "triggering_actor": {
          "avatar_url": "https://avatars.githubusercontent.com/u/64373189?v=4",
          "events_url": "https://api.github.com/users/amenes12/events{/privacy}",
          "followers_url": "https://api.github.com/users/amenes12/followers",
          "following_url": "https://api.github.com/users/amenes12/following{/other_user}",
          "gists_url": "https://api.github.com/users/amenes12/gists{/gist_id}",
          "gravatar_id": "",
          "html_url": "https://github.com/amenes12",
          "id": 64373189,
          "login": "amenes12",
          "node_id": "MDQ6VXNlcjY0MzczMTg5",
          "organizations_url": "https://api.github.com/users/amenes12/orgs",
          "received_events_url": "https://api.github.com/users/amenes12/received_events",
          "repos_url": "https://api.github.com/users/amenes12/repos",
          "site_admin": false,
          "starred_url": "https://api.github.com/users/amenes12/starred{/owner}{/repo}",
          "subscriptions_url": "https://api.github.com/users/amenes12/subscriptions",
          "type": "User",
          "url": "https://api.github.com/users/amenes12"
        },
        "updated_at": "2022-06-28T03:16:12Z",
        "url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/actions/runs/2573494098",
        "workflow_id": 27661483,
        "workflow_url": "https://api.github.com/repos/futureleadersupc/waw-backend-cs/actions/workflows/27661483"
      }
    },
    "eventName": "workflow_run",
    "sha": "5acdc6402f9cfe8c7747693986afb697ca8e50ae",
    "ref": "refs/heads/main",
    "workflow": "Reports",
    "action": "summary",
    "actor": "amenes12",
    "job": "after_run",
    "runNumber": 171,
    "runId": 2573497345,
    "apiUrl": "https://api.github.com",
    "serverUrl": "https://github.com",
    "graphqlUrl": "https://api.github.com/graphql"
  }
}

dalbitresb12
dalbitresb12 suggested changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@dalbitresb12 dalbitresb12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Can you update the test files for the Delete endpoint?

@dalbitresb12 dalbitresb12 linked an issue Jun 28, 2022 that may be closed by this pull request
DELETE endpoints return the deleted item, they should return 204 No Content #26
Closed
@dalbitresb12 dalbitresb12 merged commit d206dc4 into develop Jun 28, 2022
@dalbitresb12 dalbitresb12 deleted the fix/delete-response branch June 28, 2022 03:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dalbitresb12 dalbitresb12 dalbitresb12 approved these changes

Assignees

@amenes12 amenes12

Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
Sprint 5
Development

Successfully merging this pull request may close these issues.

DELETE endpoints return the deleted item, they should return 204 No Content
3 participants
@amenes12 @dalbitresb12-bot @dalbitresb12