This repository has been archived by the owner on Oct 14, 2022. It is now read-only.
feat: Job Manager v3 #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalbitresb12
suggested changes
Jun 24, 2022
src/app/jobs/components/job-add-dialog/job-add-dialog.component.html
Outdated
Show resolved
Hide resolved
| <button | ||
| mat-raised-button | ||
| color="warn" | ||
| class="box-border h-12 w-28" |
There was a problem hiding this comment.
box-border is already the default in Taliwind's preflight.
Suggested change
| class="box-border h-12 w-28" | |
| class="h-12 w-28" |
There was a problem hiding this comment.
@AdrianAlzamoraG I think you forgot about this one.
src/app/jobs/components/job-add-dialog/job-add-dialog.component.html
Outdated
Show resolved
Hide resolved
src/app/jobs/components/job-add-dialog/job-add-dialog.component.html
Outdated
Show resolved
Hide resolved
src/app/jobs/components/job-add-dialog/job-add-dialog.component.ts
Outdated
Show resolved
Hide resolved
Deploying with
|
| Latest commit: |
7bda13d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ecabf16f.waw-frontend-angular.pages.dev |
| Branch Preview URL: | https://feat-job-manager-v3.waw-frontend-angular.pages.dev |
dalbitresb12
suggested changes
Jun 26, 2022
Comment on lines
106
to
122
| handleSubmit() { | ||
| console.log("handling submit..."); | ||
| if (!this.jobsForm.form.valid) return; | ||
| console.log("passed validation..."); | ||
| const job = this.currentItem as JobOffer; | ||
| if (this.isEditMode) { | ||
| console.log("sending update..."); | ||
| this.updateJob(job.id, job); | ||
| } else { | ||
| console.log("sending create..."); | ||
| this.createJob(job); | ||
| } | ||
|
|
||
| this.cancelEdit(); | ||
| console.log("finished..."); | ||
| } | ||
| } |
There was a problem hiding this comment.
You forgot about the console.logs here.
|
By the way, tests are failing due to the spec file in the new dialog component. To fix it, do it as in any of the other component test files: First import the Then add it to the configuration object in |
…onent configuration object
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do
Dialogs for adding and updating bids have been implemented in the bid manager interface.
Additional context
The dialog to update offers is not yet fully implemented