Fix/migrate nft ownership #921
Conversation
…ship # Conflicts: # pallet/nft/src/tests.rs # runtime/src/migrations/mod.rs
…ship # Conflicts: # pallet/common/src/test_utils.rs # pallet/nfi/src/mock.rs # pallet/nft/src/impls.rs # pallet/nft/src/lib.rs # pallet/nft/src/mock.rs # pallet/nft/src/types.rs # pallet/nft/src/weights.rs # pallet/xls20/src/mock.rs # runtime/src/lib.rs # runtime/src/weights/pallet_nft.rs
…ship # Conflicts: # pallet/nft/src/types.rs
| // For simplicity, we will only migrate max 50 tokens from 1 account at a time | ||
| if let Some(mut ownership) = old.owned_tokens.pop() { | ||
| let mut serial_numbers = ownership.owned_serials.clone(); | ||
| // take at max 10 from serial_numbers |
There was a problem hiding this comment.
// take at max MAX_TOKENS_PER_STEP from serial_numbers
| } | ||
|
|
||
| // Update OwnedTokens with the migrated serials | ||
| let _ = pallet_nft::OwnedTokens::<T>::try_mutate( |
There was a problem hiding this comment.
we ignored the error in owned tokens update
if let Err(e) = pallet_nft::OwnedTokens::::try_mutate(
&ownership.owner,
collection_id,
|owned_serials| -> DispatchResult {
// ...
Ok(())
},
) {
log::error!(target: LOG_TARGET, "🦆 Error updating owned tokens: {:?}", e);
// Consider how to handle this error - maybe mark the migration as failed?
}
There was a problem hiding this comment.
The try_mutate will never error as we always return Ok(())
In both places where it could have errored, we are using force_push and truncate_from which do not return a Result. These are both safe as the BoundedVec upper bound will not change between the old and new datasets
so it is safe to ignore the result altogether
| @@ -134,18 +135,20 @@ pub mod pallet { | |||
|
|
|||
| // Map from a collection id to a collection's pending issuances | |||
| #[pallet::storage] | |||
| pub type PendingIssuances<T: Config> = StorageMap< | |||
| pub type PendingIssuances<T: Config> = StorageNMap< | |||
There was a problem hiding this comment.
Interesing use of new storage data structure :+1
Description
Context & Background
Notes & Additional Information
Related Issues
Release Notes
Key Changes
Type of Change
API Changes
Storage Changes
Added
Changed
Removed
Storage Migrations
Added