Skip to content
This repository has been archived by the owner on Mar 31, 2023. It is now read-only.

Commit

Permalink
[Node Mgr] Node Manager Interface for NCM Registration (#598)
Browse files Browse the repository at this point in the history
> ```
> Node Manager Interface for NCM Registration
> ```
> 
> **IMPORTANT NOTE**
> 
> * This is yet another breaking change. This commit introduces named
>   versions of NodeInfo cache in NMM, DPM and NCM. Previously, the three
>   were physically the same cache.
> 
> If any code/test assumes the existence of certain node in these caches
> before this change, they will not find those entries since this change.
> creates new caches.
> 
> * This commit also introduces an implicit assumption that bulk adding of
>   nodes can only be done to one NCM at a time. Even if each nodeinfo has a
>   distinct NCM id, NMM will pick the NCM Id from the first nodeinfo and
>   send the whole batch to that NCM (issue #601 is tracking this)
> * Node creation via file upload was meant to be an admin task and was
>   not designed to dispatch those nodes to DPM and NCM. This commit
>   does not change this old behavior (issue #600 is tracking this)
> 
> Regular change notes:
> 
> * Node creation will continue to work if nodeinfo has no ncmid to be backward
>   compatible. Delete, update file upload, bulk add all are 100% backward
>   compatible if ndmid is missing.
> * If ncmid is present, it must resolve to a registered NCM or an error will
>   be raised.
> * Update integration test script (scripts/test/nmm-ncm-test.sh) with NCM
> * id/uri. UPDATE is also validated. Added node creation with no NCMID.
> * Fix update/delete getting called through wrong methods in DPM/NCM rest
>   client code. Using rest template exchange method with correct HTTP
>   headers is required in those sites.

This is a great change note. Let us keep up the good work 👍
  • Loading branch information
pkommoju authored Apr 23, 2021
1 parent 0a58676 commit 455181e
Show file tree
Hide file tree
Showing 17 changed files with 349 additions and 179 deletions.
2 changes: 1 addition & 1 deletion lib/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -170,4 +170,4 @@ Copyright(c) 2020 Futurewei Cloud
</plugins>
</build>

</project>
</project>
15 changes: 10 additions & 5 deletions scripts/json/nodes-upload.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,39 +6,44 @@
"mac_address": "D1:A0:C9:34:C8:29",
"node_name": "upl009030",
"server_port": 50001,
"veth": "eth0"
"veth": "eth0",
"ncm_id" : "test_ncm_001"
},
{
"local_ip": "30.213.43.11",
"node_id": "e209465c-5ed6-400e-806d-fbefd12f94a9",
"mac_address": "D2:A0:C9:34:C8:29",
"node_name": "upl009031",
"server_port": 50001,
"veth": "eth0"
"veth": "eth0",
"ncm_id" : "test_ncm_001"
},
{
"local_ip": "30.213.43.13",
"node_id": "e309465c-5ed6-400e-806d-fbefd12f94a9",
"mac_address": "D3:A0:C9:34:C8:29",
"node_name": "upl009032",
"server_port": 50001,
"veth": "eth0"
"veth": "eth0",
"ncm_id" : "test_ncm_001"
},
{
"local_ip": "30.213.43.14",
"node_id": "e409465c-5ed6-400e-806d-fbefd12f94a9",
"mac_address": "D4:A0:C9:34:C8:29",
"node_name": "upl009033",
"server_port": 50001,
"veth": "eth0"
"veth": "eth0",
"ncm_id" : "test_ncm_001"
},
{
"local_ip": "30.213.43.15",
"node_id": "e509465c-5ed6-400e-806d-fbefd12f94a9",
"mac_address": "D5:A0:C9:34:C8:29",
"node_name": "upl009034",
"server_port": 50001,
"veth": "eth0"
"veth": "eth0",
"ncm_id" : "test_ncm_001"
}
]
}
Loading

0 comments on commit 455181e

Please sign in to comment.