This repository has been archived by the owner on Mar 31, 2023. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Node Mgr] Node Manager Interface for NCM Registration (#598)
> ``` > Node Manager Interface for NCM Registration > ``` > > **IMPORTANT NOTE** > > * This is yet another breaking change. This commit introduces named > versions of NodeInfo cache in NMM, DPM and NCM. Previously, the three > were physically the same cache. > > If any code/test assumes the existence of certain node in these caches > before this change, they will not find those entries since this change. > creates new caches. > > * This commit also introduces an implicit assumption that bulk adding of > nodes can only be done to one NCM at a time. Even if each nodeinfo has a > distinct NCM id, NMM will pick the NCM Id from the first nodeinfo and > send the whole batch to that NCM (issue #601 is tracking this) > * Node creation via file upload was meant to be an admin task and was > not designed to dispatch those nodes to DPM and NCM. This commit > does not change this old behavior (issue #600 is tracking this) > > Regular change notes: > > * Node creation will continue to work if nodeinfo has no ncmid to be backward > compatible. Delete, update file upload, bulk add all are 100% backward > compatible if ndmid is missing. > * If ncmid is present, it must resolve to a registered NCM or an error will > be raised. > * Update integration test script (scripts/test/nmm-ncm-test.sh) with NCM > * id/uri. UPDATE is also validated. Added node creation with no NCMID. > * Fix update/delete getting called through wrong methods in DPM/NCM rest > client code. Using rest template exchange method with correct HTTP > headers is required in those sites. This is a great change note. Let us keep up the good work 👍
- Loading branch information