Skip to content
This repository has been archived by the owner on Mar 31, 2023. It is now read-only.

[Port Mgr] Fix router resource operation type #605

Merged
merged 1 commit into from
May 1, 2021

Conversation

xieus
Copy link
Contributor

@xieus xieus commented May 1, 2021

This PR proposes a fix to two "neighbor resource operation type" issue introduced by PR #603.

Issue Description

When the network configuration message is constructed, PM needs to initialize the value of ResourceOperationTypes. The previous PR wrongly put Router type as a Neighbor type, which further introduces duplicated neighbor entities in the List.

@xieus xieus added the bug Something isn't working label May 1, 2021
@xieus xieus added this to the Version 0.12.2021.04.30 milestone May 1, 2021
@xieus xieus requested a review from cj-chung May 1, 2021 00:04
@xieus xieus self-assigned this May 1, 2021
Copy link
Contributor

@cj-chung cj-chung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #605 (71a8c86) into master (5f71b54) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #605   +/-   ##
=========================================
  Coverage     32.75%   32.75%           
  Complexity     1248     1248           
=========================================
  Files           522      522           
  Lines         13117    13117           
  Branches       1610     1610           
=========================================
+ Hits           4296     4297    +1     
+ Misses         8236     8235    -1     
  Partials        585      585           
Impacted Files Coverage Δ Complexity Δ
...lcor/portmanager/processor/DataPlaneProcessor.java 69.72% <100.00%> (ø) 39.00 <0.00> (ø)
...alcor/elasticipmanager/dao/ElasticIpAllocator.java 63.81% <0.00%> (+0.27%) 48.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f71b54...71a8c86. Read the comment docs.

@xieus xieus merged commit 0777179 into futurewei-cloud:master May 1, 2021
@xieus xieus deleted the pm/fix branch May 1, 2021 03:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants