Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pass through binding logic. #570

Merged
merged 1 commit into from
Jul 7, 2021
Merged

Fix pass through binding logic. #570

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 15 additions & 17 deletions fvwm/bindings.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,34 +392,32 @@ static int ParseBinding(
if (action != NULL)
{
action = SkipSpaces(action, NULL, 0);
if (action != NULL)
is_pass_through = is_pass_through_action(action);
}
if (
action == NULL || *action == 0 ||
(action[0] == '-' && !is_pass_through))
{
is_unbind_request = True;
}
else
else if (is_pass_through)
{
is_pass_through = is_pass_through_action(action);
if (is_pass_through)
/* pass-through actions indicate that the event be
* allowed to pass through to the underlying window. */
if (window_name == NULL)
{
/* pass-through actions indicate that the event be
* allowed to pass through to the underlying window. */
if (window_name == NULL)
/* It doesn't make sense to have a pass-through
* action on global bindings. */
if (!is_silent)
{
/* It doesn't make sense to have a pass-through
* action on global bindings. */
if (!is_silent)
{
fvwm_debug(
__func__,
"Invalid action for global "
"binding: %s", tline);
}

return 0;
fvwm_debug(
__func__,
"Invalid action for global "
"binding: %s", tline);
}

return 0;
}
}

Expand Down