BroadcastMonitorList: send DesktopSize once #998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When updating modules about changes to monitors, etc., only send the DesktopSize command once, as this is proliferated for every module for all pages, which is redundant. Fixes #997
ThomasAdam
changed the title
ThomasAdam
added
type:bug
When a module requests information about what it needs to know, it does so to fvwm by asking "Send_ConfigInfo". However, if this happens, and fvwm is already sending information to all modules (such as via a DesktopSize command), then an infinite loop can take place. Fixes #997
somiaj
added a commit
that referenced
this pull request
Apr 22, 2024
Still send DesktopConfigurtion when initializing a module. #998 went a tad too far stopping both Monitor and DesktopConfiguration broadcasts at init. This splits DesktopConfiguration broadcasts into their own method so they can be included in the initial broadcasts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating modules about changes to monitors, etc., only send the
DesktopSize command once, as this is proliferated for every module for
all pages, which is redundant.
Fixes #997