Skip to content

Commit

Permalink
Make AspectTest.topLevelConflictDetected not flaky.
Browse files Browse the repository at this point in the history
The message relied on the order in which the two aspects were analyzed.

RELNOTES: None.
PiperOrigin-RevId: 359713477
  • Loading branch information
lberki authored and philwo committed Feb 26, 2021
1 parent 7b3f56d commit fa9aabe
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -959,9 +959,9 @@ public void topLevelConflictDetected() throws Exception {
"//foo:foo"));
assertThat(exception)
.hasMessageThat()
.contains(
"ConflictException: for foo/aspect.out, previous action: action 'Action for aspect 1',"
+ " attempted action: action 'Action for aspect 2'");
.containsMatch(
"ConflictException: for foo/aspect.out, previous action: action 'Action for aspect .',"
+ " attempted action: action 'Action for aspect .'");

// Fix bzl file so actions are shared: analysis should succeed now.
scratch.overwriteFile("foo/aspect.bzl", String.format(bzlFileTemplate, "1"));
Expand Down

0 comments on commit fa9aabe

Please sign in to comment.