Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this tool relevant anymore? #174

Closed
mahozad opened this issue Sep 7, 2021 · 8 comments
Closed

Is this tool relevant anymore? #174

mahozad opened this issue Sep 7, 2021 · 8 comments

Comments

@mahozad
Copy link

mahozad commented Sep 7, 2021

Now that GitHub actions environments have Kotlin pre-installed (issue, YouTube announcement), do I need this tool anymore in my actions?

@fwilhe2
Copy link
Owner

fwilhe2 commented Sep 7, 2021

Hi @mahozad

I've seen that GitHub added Kotlin to the runner environments, and I think that's a great change.

I think there are still some cases where this action provides additional benefit.

For example if you want to make use of the Kotlin native compiler, or if you want to chose a specific Kotlin version, or if your Workflow runs inside a Container or Self-Hosted runner.

But overall I think for most users you are probably right that this action has been replaced with a better solution, so if you don't need it anymore, I encourage you to remove it from your workflows.

Kind regards

Florian

@fwilhe2
Copy link
Owner

fwilhe2 commented Sep 7, 2021

I've updated the hint in the readme, I hope that helps people to judge if the action is useful to them.

Screenshot from 2021-09-07 21-49-08

Please let me know if you have any suggestions for writing this more clearly.

@mahozad
Copy link
Author

mahozad commented Sep 8, 2021

@fwilhe2 That's good. Thank you.

@JavierSegoviaCordoba
Copy link

Built in solution doesn’t allow inline scripts no?

@fwilhe2
Copy link
Owner

fwilhe2 commented Oct 15, 2021

Built in solution doesn’t allow inline scripts no?

Depends on what you want, but since you can use Kotlin as a "shell" I think you don't need this action to use inline Kotlin in your workflows as in this example:

jobs:
  build:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
      - run: |
            java.io.File(".").listFiles().forEach {it -> println(it.getName().toString())}
        shell: kotlin -howtorun .main.kts {0}

I've liked respective issues here. If you don't need a specific Kotlin version, you don't need this action to do that. I've just tested it here.

@JavierSegoviaCordoba
Copy link

JavierSegoviaCordoba commented Oct 15, 2021

but that works? I tried it two weeks ago and it was not working without your action 🤔

Thank you for the info 😃

@JavierSegoviaCordoba
Copy link

Do you know a tutorial about how to migrate from bash to kotlin the typical things like setting an output and so on?

@christianhujer
Copy link

Is this tool still relevant? I don't know, maybe. I just used this despite Kotlin being available on GitHub actions out of the box because I needed Kotlin 1.6.0 and the GitHub actions only had 1.5.31. And I couldn't figure out how to tell GitHub actions to use Kotlin 1.6.0 instead of 1.5.31 in any other way than using this tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants