-
Notifications
You must be signed in to change notification settings - Fork 17
Conversation
@fwouts durable_rules is one that I have had break on me in the past. I also had a coworker complain about node-sass not working, which is probably more popular. |
Thanks, I got it failing successfully now. This might take a while to fix :) |
This should help address #13.
This contains a hacky workaround using npm rebuild when the image is started.
df98825
to
f98f61a
Compare
@fwouts It's possible that Bazel just doesn't have the concepts to address the native modules yet. I think that (in my limited understanding) the issues Skylark supports multi-architecture ("fat") binaries and Skylark supports platform transitions might add the concepts to Bazel that can deal with this? I think that I could use something like dazel so that the yarn install was run inside a docker container. But I think that file IO with mounted volumes is fairly slow. In the meantime, I think that your workaround looks like it would be the best solution. Probably a hit to startup time. Or I might be able to find a way to run that command with kaniko as a final build step. |
Thanks, lots of good ideas. FYI I also toyed with the idea of setting the target platform with There's also https://github.com/bazelbuild/bazel-toolchains that looks interesting (but requires being run in a remote environment). In the meantime, I'll get this merged in (the CircleCI error is unrelated (bazelbuild/bazel#5964). |
This should help address part of #13.
@enriched could you give an example of native node module that would break with this?