This repository has been archived by the owner on Jun 5, 2021. It is now read-only.
Use the MiniCssExtractPlugin loader in prod mode #42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi again, @fwouts 👋
I noticed that the
MinCssExtractPlugin
was being wired up in the plugins, but that my bundles didn't contain.css
files.https://github.com/zenclabs/bazel-javascript/blob/68f8fbb/internal/web_bundle/create_webpack_config.js#L206-L213
This PR uses the
MiniCssExtractPlugin.loader
inproduction
mode andstyle-loader
otherwise, per https://github.com/webpack-contrib/mini-css-extract-plugin#advanced-configuration-exampleMy bundle now looks like:
Thanks again for these rules!