Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: CI should test more Go versions when actions/setup-go fixes performance issue #203

Closed
x448 opened this issue Mar 26, 2020 · 1 comment · Fixed by #286
Closed

chore: CI should test more Go versions when actions/setup-go fixes performance issue #203

x448 opened this issue Mar 26, 2020 · 1 comment · Fixed by #286
Assignees
@x448
Labels
CI CI using GitHub Actions Workflow
Milestone
v2.3.1

Comments

@x448
Copy link
Contributor

x448 commented Mar 26, 2020 •
edited
Loading

GitHub's ubuntu-latest image recently started to include 4 versions of Go (1.11.x - 1.14.x). However, actions/setup-go downloads and installs Go if any version != 1.14 is specified.

The preinstalled Go versions can be leveraged by GitHub's setup/go so it won't cause a 10 sec delay during CI for each specified version of Go.

If and when the following setup/go issue is fixed, use the matrix feature of GitHub Workflow Actions to test the latest 3 versions of Go:

actions/setup-go#39
@fxamacker fxamacker added the waiting Waiting for reply or action label Mar 26, 2020
@fxamacker
Copy link
Owner

Looks like actions/setup-go#39 got fixed! 🎉

@fxamacker fxamacker removed the waiting Waiting for reply or action label Mar 31, 2021
@fxamacker fxamacker added the CI CI using GitHub Actions Workflow label May 29, 2021
@fxamacker fxamacker added this to the v2.4.0 milestone May 31, 2021
x448 added a commit to x448/cbor that referenced this issue Jun 3, 2021
@x448
Update ci.yml
d1dd18b 
Expand matrix to 3 os x 3 go versions.

closes fxamacker#203
@x448 x448 mentioned this issue Jun 3, 2021
Merged
fxamacker pushed a commit that referenced this issue Jun 3, 2021
@x448
Update ci.yml (#286)
ffaad45 
Expand matrix to 3 os x 3 go versions.

closes #203
@fxamacker fxamacker modified the milestones: v2.4.0, v2.3.1 Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@x448 x448

Labels
CI CI using GitHub Actions Workflow
Projects
None yet
Milestone
v2.3.1
Development

Successfully merging a pull request may close this issue.

Update ci.yml x448/cbor
2 participants
@fxamacker @x448