Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sort offers by floorDifference #72

Merged
merged 9 commits into from
Apr 6, 2023
Merged

sort offers by floorDifference #72

merged 9 commits into from
Apr 6, 2023

Conversation

louisholley
Copy link
Contributor

@louisholley louisholley commented Apr 5, 2023 •
edited
Loading

this pr:

  • implements sorting offers by floorDifference
  • adds tests for offers/collection offers related queries

@louisholley louisholley changed the title collection offers tests sort offers by floorDifference Apr 6, 2023
louisholley
louisholley commented Apr 6, 2023
View reviewed changes
src/Query/Filters/Offer.ts
const sortDirection = sort[sortProperty]

// workaround for the floorDifference computed column
if (sortProperty === "floorDifference") {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to have a manual workaround for floorDifference as I can't get typeorm to return it from the query 😕

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's validate for the time being and extract it as a github issue to tackle on eventually

@louisholley louisholley mentioned this pull request Apr 6, 2023
Open
@louisholley louisholley merged commit 05c4b99 into dev Apr 6, 2023
@louisholley louisholley deleted the feat/collection-offers-test branch April 6, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GemN GemN GemN approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louisholley @GemN