Serialisation improvements #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Major simplifications of various fxparam related functions: - add U8/32/64 hex formatters - add asBytes() hexbyte string parser - add minmax() helper for enforcing optional ranges and dedupe logic - update/simplify rgbaToHex()() - update completeHexColor(): - add 4-digit hex color support - fix: enforce 8-digit result (even if incomplete input) - update/simplify serializers/deserializers for all param types - fix string param serialization to safely handle non-ASCII chars (using UTF-8 representation) - add/update docstrings
* upstream/master: build build fix: only push params if definitions defined in code build added minter address to the panel update build receive snippet version; allow user defined max length on string param only warn type any
maerzhase
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR incorporates the serialiser improvements provided by #18