Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
offline_as_scope
config option doesn't currently do anything because the variable gets overridden by the supported scopes from the OIDC issuer (or just set to true if the issuer doesn't advertise the supported scopes). This PR:OfflineAsScope
config option to a*bool
so that we can differentiate between intentionally set in the config file and omitted (if there's a better approach in Go, I'd be interested in knowing)OfflineAsScope
optionclient-secret
andrefresh-token
options in the kubeconfig file (idp-issuer-url
andclient-secret
are both still required without a refresh token)