Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor background task completed #449

Merged
merged 8 commits into from
Jul 6, 2023
Merged

Refactor background task completed #449

merged 8 commits into from
Jul 6, 2023

Conversation

ruuushhh
Copy link
Contributor

No description provided.

@ruuushhh ruuushhh requested a review from ashwin1111 June 26, 2023 06:21
@ruuushhh ruuushhh self-assigned this Jun 26, 2023
@ruuushhh ruuushhh temporarily deployed to CI Environment June 26, 2023 06:21 — with GitHub Actions Inactive
@ruuushhh ruuushhh temporarily deployed to CI Environment June 26, 2023 06:21 — with GitHub Actions Inactive
@ruuushhh ruuushhh changed the title Refactoring completed Refactor background task completed Jun 26, 2023
@github-actions
Copy link

Tests Skipped Failures Errors Time
179 0 💤 0 ❌ 0 🔥 35.077s ⏱️

@github-actions
Copy link

Tests Skipped Failures Errors Time
179 0 💤 0 ❌ 0 🔥 35.075s ⏱️

@codecov
Copy link

codecov bot commented Jun 26, 2023 •
edited
Loading

Codecov Report

Merging #449 (ae38951) into master (8dbbd13) will decrease coverage by 0.95%.
The diff coverage is 99.43%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #449      +/-   ##
==========================================
- Coverage   97.00%   96.06%   -0.95%     
==========================================
  Files          50       54       +4     
  Lines        4078     4093      +15     
==========================================
- Hits         3956     3932      -24     
- Misses        122      161      +39
Impacted Files Coverage Δ
apps/fyle/tasks.py 87.87% <ø> (-0.13%) ⬇️
apps/mappings/tasks.py 94.88% <ø> (-0.19%) ⬇️
apps/workspaces/apis/import_settings/triggers.py 98.57% <50.00%> (-0.04%) ⬇️
apps/mappings/queue.py 98.14% <98.14%> (ø)
apps/mappings/signals.py 100.00% <100.00%> (ø)
apps/mappings/views.py 100.00% <100.00%> (ø)
apps/quickbooks_online/queue.py 100.00% <100.00%> (ø)
apps/quickbooks_online/tasks.py 96.17% <100.00%> (-0.84%) ⬇️
apps/workspaces/actions.py 100.00% <100.00%> (ø)
...orkspaces/apis/advanced_configurations/triggers.py 100.00% <100.00%> (ø)
... and 7 more

... and 1 file with indirect coverage changes

@github-actions
Copy link

Tests Skipped Failures Errors Time
179 0 💤 6 ❌ 0 🔥 36.064s ⏱️

@ruuushhh ruuushhh temporarily deployed to CI Environment June 26, 2023 06:57 — with GitHub Actions Inactive
@github-actions
Copy link

Tests Skipped Failures Errors Time
179 0 💤 0 ❌ 0 🔥 36.143s ⏱️

ashwin1111
ashwin1111 reviewed Jun 26, 2023
View reviewed changes
apps/mappings/signals.py Show resolved Hide resolved
fyle_qbo_api/queue.py Outdated Show resolved Hide resolved
@ruuushhh ruuushhh temporarily deployed to CI Environment June 27, 2023 08:25 — with GitHub Actions Inactive
@github-actions
Copy link

Tests Skipped Failures Errors Time
179 0 💤 0 ❌ 0 🔥 49.008s ⏱️

@ruuushhh ruuushhh requested a review from ashwin1111 June 27, 2023 08:30
ashwin1111
ashwin1111 reviewed Jun 27, 2023
View reviewed changes
apps/mappings/queue.py Outdated Show resolved Hide resolved
apps/mappings/utils.py Outdated Show resolved Hide resolved
apps/workspaces/queue.py Outdated Show resolved Hide resolved
apps/workspaces/queue.py Outdated Show resolved Hide resolved
apps/workspaces/queue.py Outdated Show resolved Hide resolved
apps/workspaces/queue.py Outdated Show resolved Hide resolved
apps/workspaces/queue.py Outdated Show resolved Hide resolved
apps/workspaces/queue.py Outdated Show resolved Hide resolved
@ruuushhh ruuushhh temporarily deployed to CI Environment June 28, 2023 07:34 — with GitHub Actions Inactive
@github-actions
Copy link

Tests Skipped Failures Errors Time
178 0 💤 0 ❌ 0 🔥 43.768s ⏱️

@ruuushhh ruuushhh requested a review from ashwin1111 June 28, 2023 10:11
@ruuushhh ruuushhh temporarily deployed to CI Environment June 28, 2023 10:45 — with GitHub Actions Inactive
@github-actions
Copy link

Tests Skipped Failures Errors Time
177 0 💤 0 ❌ 0 🔥 28.325s ⏱️

@ruuushhh ruuushhh temporarily deployed to CI Environment July 6, 2023 09:38 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

Tests Skipped Failures Errors Time
178 0 💤 0 ❌ 0 🔥 35.724s ⏱️

@ruuushhh ruuushhh temporarily deployed to CI Environment July 6, 2023 10:27 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

Tests Skipped Failures Errors Time
175 0 💤 0 ❌ 0 🔥 45.470s ⏱️

@ruuushhh ruuushhh merged commit 5900875 into master Jul 6, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwin1111 ashwin1111 ashwin1111 approved these changes

Assignees

@ruuushhh ruuushhh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruuushhh @ashwin1111