Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Last export p0 fixed #453

Merged
merged 3 commits into from
Jul 6, 2023
Merged

Last export p0 fixed #453

merged 3 commits into from
Jul 6, 2023

Conversation

ruuushhh
Copy link
Contributor

@ruuushhh ruuushhh commented Jul 6, 2023

No description provided.

@ruuushhh ruuushhh requested a review from ashwin1111 July 6, 2023 12:10
@ruuushhh ruuushhh self-assigned this Jul 6, 2023
@ruuushhh ruuushhh temporarily deployed to CI Environment July 6, 2023 12:10 — with GitHub Actions Inactive
@ruuushhh ruuushhh temporarily deployed to CI Environment July 6, 2023 12:10 — with GitHub Actions Inactive
ashwin1111
ashwin1111 approved these changes Jul 6, 2023
View reviewed changes
apps/quickbooks_online/exceptions.py Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

Tests Skipped Failures Errors Time
175 0 💤 0 ❌ 0 🔥 36.847s ⏱️

@ruuushhh ruuushhh temporarily deployed to CI Environment July 6, 2023 12:13 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

Tests Skipped Failures Errors Time
175 0 💤 0 ❌ 0 🔥 36.636s ⏱️

@codecov
Copy link

codecov bot commented Jul 6, 2023 •
edited
Loading

Codecov Report

Merging #453 (fcc41a6) into master (8dbbd13) will decrease coverage by 0.96%.
The diff coverage is 100.00%.

❗ Current head fcc41a6 differs from pull request most recent head 2486017. Consider uploading reports for the commit 2486017 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #453      +/-   ##
==========================================
- Coverage   97.00%   96.05%   -0.96%     
==========================================
  Files          50       51       +1     
  Lines        4078     4084       +6     
==========================================
- Hits         3956     3923      -33     
- Misses        122      161      +39
Impacted Files Coverage Δ
apps/quickbooks_online/actions.py 100.00% <100.00%> (ø)
apps/quickbooks_online/exceptions.py 94.66% <100.00%> (+0.22%) ⬆️
apps/quickbooks_online/tasks.py 96.96% <100.00%> (-0.05%) ⬇️

... and 4 files with indirect coverage changes

@ashwin1111 ashwin1111 added the deploy Triggers deployment of active branch to Staging label Jul 6, 2023
@ashwin1111 ashwin1111 temporarily deployed to CI Environment July 6, 2023 12:15 — with GitHub Actions Inactive
@ashwin1111 ashwin1111 temporarily deployed to Staging July 6, 2023 12:15 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

Tests Skipped Failures Errors Time
175 0 💤 0 ❌ 0 🔥 47.703s ⏱️

@ruuushhh ruuushhh temporarily deployed to CI Environment July 6, 2023 17:22 — with GitHub Actions Inactive
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

Tests Skipped Failures Errors Time
175 0 💤 0 ❌ 0 🔥 40.361s ⏱️

@ruuushhh ruuushhh merged commit 3a6fb10 into master Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NileshPant1999 NileshPant1999 NileshPant1999 approved these changes

@ashwin1111 ashwin1111 ashwin1111 approved these changes

Assignees

@ruuushhh ruuushhh

Labels
deploy Triggers deployment of active branch to Staging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ruuushhh @ashwin1111 @NileshPant1999