-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Max retry limit for bill payment #664
base: master
Are you sure you want to change the base?
Conversation
WalkthroughThis update introduces a new Boolean field, Changes
Poem
Tip We have updated our review workflow to use the Anthropic's Claude family of models. Please share any feedback in the discussion post on our Discord. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (5)
- apps/quickbooks_online/migrations/0015_bill_is_retired.py (1 hunks)
- apps/quickbooks_online/models.py (1 hunks)
- apps/quickbooks_online/tasks.py (3 hunks)
- tests/sql_fixtures/reset_db_fixtures/reset_db.sql (6 hunks)
- tests/test_quickbooks_online/test_tasks.py (2 hunks)
Additional comments not posted (7)
tests/sql_fixtures/reset_db_fixtures/reset_db.sql (3)
Line range hint
1-1
: LGTM!The changes to the
bills
table schema are approved. The addition of theis_retired
column with a NOT NULL constraint is a significant change that will enhance the functionality of thebills
table by allowing the retirement status of bills to be tracked.
Line range hint
2-2
: LGTM!The changes to the
COPY
command for thebills
table are approved. The inclusion of theis_retired
column is necessary to accommodate the changes to thebills
table schema.
3-3
: LGTM!The changes to the
SELECT pg_catalog.setval
statement are approved. The increment in the sequence value fordjango_migrations_id_seq
correctly reflects the addition of a new migration related to the changes in thebills
table schema.apps/quickbooks_online/tasks.py (2)
634-655
: LGTM!The code changes are approved.
671-673
: LGTM!The code changes are approved.
apps/quickbooks_online/models.py (1)
197-197
: LGTM!The new
is_retired
field is properly defined in theBill
model with a clear purpose and an appropriate default value.tests/test_quickbooks_online/test_tasks.py (1)
1289-1354
: LGTM!The new test function
test_skipping_bill_payment
is well-structured and covers the important scenarios for skipping bill payments based on task log timestamps. It uses mocking to isolate the test from external dependencies and makes appropriate assertions to verify the expected behavior in each scenario.
migrations.AddField( | ||
model_name='bill', | ||
name='is_retired', | ||
field=models.BooleanField(default=False, help_text='Is Payment sync retried'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistency between the field name and the help_text
.
The field name is_retired
implies that the bill is retired, but the help_text
implies that the field is used to track if the payment sync is retried.
Consider updating the field name or the help_text
to ensure consistency. For example:
-field=models.BooleanField(default=False, help_text='Is Payment sync retried'),
+field=models.BooleanField(default=False, help_text='Is the bill retired'),
or
-name='is_retired',
-field=models.BooleanField(default=False, help_text='Is Payment sync retried'),
+name='is_payment_sync_retried',
+field=models.BooleanField(default=False, help_text='Is Payment sync retried'),
Committable suggestion was skipped due to low confidence.
Summary by CodeRabbit
New Features
is_retired
field to the bill model for enhanced tracking of payment synchronization attempts.Bug Fixes
Tests
Chores
is_retired
column in the bills table.