[widget][theme] use warningOnBackground color instead of warning wher…

…e appropriate
fyne-io · Jun 22, 2024 · 7641a44 · 7641a44
1 parent 02db92e
commit 7641a44
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/theme/icons.go b/theme/icons.go
@@ -679,7 +679,7 @@ func NewThemedResource(src fyne.Resource) *ThemedResource {
 func NewWarningThemedResource(src fyne.Resource) *ThemedResource {
  return &ThemedResource{
  source: src,
- ColorName: ColorNameWarning,
+ ColorName: ColorNameWarningOnBackground,
  }
 }
 

diff --git a/theme/icons_test.go b/theme/icons_test.go
@@ -157,11 +157,11 @@ func TestThemedResource_Warning(t *testing.T) {
  fyne.CurrentApp().Settings().SetTheme(theme.DarkTheme())
  source := helperNewStaticResource()
  custom := theme.NewThemedResource(source)
- custom.ColorName = theme.ColorNameWarning
+ custom.ColorName = theme.ColorNameWarningOnBackground
 
- assert.Equal(t, custom.Name(), fmt.Sprintf("warning_%v", source.Name()))
+ assert.Equal(t, custom.Name(), fmt.Sprintf("warningOnBackground_%v", source.Name()))
  custom = theme.NewWarningThemedResource(source)
- assert.Equal(t, custom.Name(), fmt.Sprintf("warning_%v", source.Name()))
+ assert.Equal(t, custom.Name(), fmt.Sprintf("warningOnBackground_%v", source.Name()))
 }
 
 func TestDisabledResource_Name(t *testing.T) {

diff --git a/widget/label.go b/widget/label.go
@@ -134,7 +134,7 @@ func (l *Label) syncSegments() {
  case DangerImportance:
  color = theme.ColorNameErrorOnBackground
  case WarningImportance:
- color = theme.ColorNameWarning
+ color = theme.ColorNameWarningOnBackground
  case SuccessImportance:
  color = theme.ColorNameSuccessOnBackground
  default:

diff --git a/widget/testdata/label/label_importance_warning.png b/widget/testdata/label/label_importance_warning.png