Feature/card (retry) #1263
Merged
Feature/card (retry) #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xt with content and image header Any of these can be omitted as the tests verify
5 tasks
stuartmscott
suggested changes
Aug 28, 2020
|
Re:
To what end? If you think every permutation of options should be tested please say so - I added the ones you thought were missing, and this list is additional to that. Do you also need subtitle with content, subtitle with image, what about with just title missing as well? |
|
Sorry, my initial list should have been more comprehensive to avoid a back and forth. I don't think we need every permutation, just the main ones a dev is expected to use. |
|
OK, I think If I add titles+image and all4 we should have pretty good coverage |
|
That should be everything now |
stuartmscott
approved these changes
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
A basic card container with header, subheader, content and image - all optional.
We can add more to this later, such as the buttons (style challenges as they are depicted like hyperlink...?)
Deprecate Group in favour of CardContainer and use it in a few places where group was before.
Tests are just image comparison at this time as it's a pretty simple linear layout.
Checklist: