Feature/systray

[andydotxyz]

Description:

Add support for system tray on macOS, Windows and Linux/BSD.
This adds a 6% increase in binary size, but I cannot find a way to do this with less.

Fixes #283

Checklist:

• Tests included.
• Lint and formatter run with no errors.
• Tests all pass.

Where applicable:

• Public APIs match existing style.
• Updated the vendor folder (using go mod vendor).
• Check for binary size increases when importing new modules.

[Bluebugs]

Just wondering if the icon approach is the right one here. I haven't used systray on multiple platform, but it doesn't seems to be an in sync behavior on Linux. You can have "blinky" icon in the systray, but I haven't noticed them much in the application window icon.

[andydotxyz]

Can you clarify what you mean by whether “the icon approach” being right @Bluebugs ? I’m not sure what aspect is being questioned.

[Bluebugs]

My understanding is that the current PR does use the application icon as the one for the systray icon. This might be limiting, especially because icon are usually "animated" or show some kind of state information by changing there content, which I don't think is necessarily expected for the application icon. Basically I am not sure that they have the same purpose.

[andydotxyz]

My understanding is that the current PR does use the application icon as the one for the systray icon. This might be limiting, especially because icon are usually "animated" or show some kind of state information by changing there content, which I don't think is necessarily expected for the application icon. Basically I am not sure that they have the same purpose.

Thanks. The plan is that this will be the fallback but developers will be able to specify an override, I hope this makes sense (I do still need to add that API).
Plan is that by default the icons will be the same (no user surprise), but that they can be animated etc by setting different ones.

[Bluebugs]

The plan is that this will be the fallback but developers will be able to specify an override, I hope this makes sense (I do still need to add that API). Plan is that by default the icons will be the same (no user surprise), but that they can be animated etc by setting different ones.

That does make sense indeed.

[coveralls]

Coverage decreased (-0.1%) to 61.713% when pulling 070c7ae on andydotxyz:feature/systray into e12f3a2 on fyne-io:develop.

[andydotxyz]

Icon replace is in and this seems feature complete.
I cannot figure how to make tests for it, but open to suggestions.

[stuartmscott]

I cannot figure how to make tests for it, but open to suggestions.

Seems tricky as it is such an OS-dependent API. I'm not even sure you can programmatically trigger system tray elements on most OSes.

It might be good to add a couple of usage tests tho - to ensure it doesn't break if someone calls the APIs, or calls them in the wrong order, or updates the menu & icon every frame, and that the icon adjusts to theme-changes etc.

[andydotxyz]

It might be good to add a couple of usage tests tho - to ensure it doesn't break if someone calls the APIs, or calls them in the wrong order, or updates the menu & icon every frame, and that the icon adjusts to theme-changes etc.

But if we call any of these APIs then icons will appear and disappear from system tray, something we generally try to avoid in tests. Such testing should be in the fyne-io/systray package not here I would think.

[stuartmscott]

Running fyne test already flashes up windows and changes the menus in the top bar, icons appearing and disappearing from the system tray isn't the end of the world

[andydotxyz]

Running fyne test already flashes up windows and changes the menus in the top bar

Only on macOS IIRC. And it's a bit of a regression, we used to manage without visually interfering with the screen.

[andydotxyz]

Is not having the test in a blocker @stuartmscott? I would happily add some Os specific testing to the "systray" project, the only thing to test here really is that a fyne.Menu translates to a systray menu, I guess that would be possible?

[andydotxyz]

Sorry @Bluebugs I did an update and it invalidated your review :(

[stuartmscott]

I would happily add some Os specific testing to the "systray" project

Sounds good!

The only other thing to check is that the Icon updates on theme change

[andydotxyz]

The only other thing to check is that the Icon updates on theme change

Wow now that is an interesting thought. I don't think any of our app/window icon code refreshes on theme change.
Most icons like that are not part of the theme but I guess it is entirely possible that they could be and/or would want to match the current settings.

[stuartmscott]

Remaining items could land in a follow up PR. This feature is in high demand so let's land it and get it in the hands of devs for testing.

[andydotxyz]

Remaining items could land in a follow up PR.

Added #2842 to follow up on the icon theme change

[andydotxyz]

Jacob said continue without him, so I did