Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crazy peak in memory when moving selection #3431

Merged
merged 2 commits into from
Nov 28, 2022
Merged

Fix crazy peak in memory when moving selection #3431

merged 2 commits into from
Nov 28, 2022

Conversation

andydotxyz
Copy link
Member

There is an underlying issue where text refresh memory is not freed

but here we are able to avoid refresh which is always good.
Fixes #3426

Checklist:

  • Tests included. <- an optimisation
  • Lint and formatter run with no errors.
  • Tests all pass.

@andydotxyz
Fix crazy peak in memory when moving selection
71888a7 
There is an underlying issue where text refresh memory is not freed

but here we are able to avoid refresh which is always good.
Fixes fyne-io#3426
@coveralls
Copy link

coveralls commented Nov 26, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.009%) to 61.755% when pulling f0961b0 on andydotxyz:fix/3426 into f98e120 on fyne-io:develop.

Jacalz
Jacalz requested changes Nov 27, 2022
View reviewed changes
Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Just noted a small simplification to the Boolean logic :)

widget/entry.go Outdated Show resolved Hide resolved
Jacalz
Jacalz approved these changes Nov 28, 2022
View reviewed changes
Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well. I do not see any drastic increase when moving the cursor 👍

@andydotxyz andydotxyz merged commit d59bcb2 into fyne-io:develop Nov 28, 2022
@andydotxyz andydotxyz deleted the fix/3426 branch November 28, 2022 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jacalz Jacalz Jacalz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andydotxyz @coveralls @Jacalz